Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce must return an interface to support multiple type #50

Closed
kubino opened this issue Oct 31, 2018 · 2 comments
Closed

Reduce must return an interface to support multiple type #50

kubino opened this issue Oct 31, 2018 · 2 comments
Labels
enhancement

Comments

@kubino
Copy link

kubino commented Oct 31, 2018

Hi I would like to use Reduce function but it seems that output result must be always float64, so no Map or Array or whatever else is supported? I am completely new to Go maybe I am missing something. Thank you for your help.
@thoas
Copy link
Owner

thoas commented Nov 8, 2018

You are right, it seems the Reduce has been done only for integer at the moment feel free to send a patch to support others operations.

@thoas thoas changed the title Reduce must return float64 ? Reduce must return an interface to support multiple type Nov 8, 2018
@reetuparna
Copy link
Contributor

reetuparna commented Jul 31, 2020 •
edited
Loading

Taking this up @thoas

vellotis added a commit to vellotis/go-funk that referenced this issue Mar 10, 2021
@vellotis
thoas#50 Change funk.Reduce return type to interface{}
a365a2b
vellotis added a commit to vellotis/go-funk that referenced this issue Mar 10, 2021
@vellotis
thoas#50 Fix tests
442500c
vellotis added a commit to vellotis/go-funk that referenced this issue Mar 10, 2021
@vellotis
thoas#50 Update README
cdeac5b
@vellotis vellotis mentioned this issue Mar 10, 2021
Merged
thoas added a commit that referenced this issue Mar 11, 2021
@thoas
Merge pull request #116 from vellotis/#50
6d0684b 
Fixes issue #50
@thoas thoas closed this as completed Mar 11, 2021
This was referenced Mar 12, 2021
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thoas @kubino @reetuparna