Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some optimisations and fixed warnings #9

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Some optimisations and fixed warnings #9

wants to merge 26 commits into from

Conversation

bachandi
Copy link

@bachandi bachandi commented May 19, 2020 •
edited
Loading

Based on the PR from Mart-Muc I added some additional improvements. Please have a look:

  • Replace usage of temporary files by direct access to the command output
  • Remove warning due to missing optional characteristic
  • Remove superfluous 'request' dependency
  • Add verboseLogging config option to print temperatures in the log file
  • Add 'historySize' config option
  • Add RAM usage information

Mart-Muc and others added 26 commits March 18, 2020 11:52
@Mart-Muc
getModel added
613b5be 
the hard coded PI3 String in the Accessory Descripten was replaced, with an automatic Model detection.
Working directory changed to ->/tmp/
@bachandi
Simplify file usage
5d7c77b
@bachandi
Simplifing getting the model
1ce50e7
@bachandi
Remove temporary files completely
dad1d8d
@bachandi
Add verboseLogging config option to print temperatures in the log file
1e19073
@bachandi
Update example config
f392912
@bachandi
Rename variable to better reflect what it is
9851dae
@bachandi
Remove request dependency
17e9257
@bachandi
Add some dokumentation on unique serial number
84e1ab0
@bachandi
Remove warning due to missing optional characteristic
1086f5a
@bachandi
Disable automatic timer as we do it by ourself
c7acb62
@bachandi
Add historySize option to the config file
984fabd
@bachandi
Add ram usage characteristics
1ac7bfb
@bachandi
Add language options
a29929f
@bachandi
Add more translations
ae460bf
@bachandi
Some cleanup
af4b138
@bachandi
Add option to enable mean timer
05f8858
@bachandi
Add better localizatoin support
32c64bb
@bachandi
Disable repetition of last data point if there are none.
e047765
@bachandi
Add throttling status
ea04906
@bachandi
Add disk and swap usage
8b6db95
@bachandi
Add custom command script option
4e26186
@bachandi
Cleanup seperator usage
d8cfa79
@bachandi
Fix ram usage
47e8493
@bachandi
Increase version
f0388c3
@bachandi
Fix typo
a39e6be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bachandi @Mart-Muc