Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: macOS build+test action #39

Closed

Conversation

SecondFlight
Copy link
Collaborator

This patch adds a build+test action for macOS.

Passing build here: https://github.com/SecondFlight/rid/pull/5

@SecondFlight SecondFlight added cli macos Issues/PRs related to using rid on macOS (osx) labels Oct 8, 2021
@thlorenz
Copy link
Owner

Awesome I very much like it!

Ideally we'd add this directly to the main build yaml along the lines of this?
I'm already using matrix builds and you can adapt the installation of things like make by defining vars for each OS as shown in the example I linked.

An alternative, but not as desirable would be splitting install tasks out and using runs-on to use the proper ones for each OS. This we should use if something cannot be solved via env vars.

Rough example:

ubuntu-deps:
    runs-on: ubuntu-latest
    steps:
     .....
macos-deps:
    runs-on: macos-latest
    steps:
     .....

Either approach would avoid duplicating other parts of the build config in several files and having to update them in multiple places if they change.

LMK if you need help with this and thanks!

@thlorenz thlorenz mentioned this pull request Oct 10, 2021
@SecondFlight
Copy link
Collaborator Author

Closing in favor of #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli macos Issues/PRs related to using rid on macOS (osx)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants