Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Traceur to version 0.0.90 #85

Closed
wants to merge 1 commit into from
Closed

Bump Traceur to version 0.0.90 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"homepage": "https://thlorenz.github.io/es6ify/",
"dependencies": {
"through": "~2.2.7",
"traceur": "0.0.79",
"traceur": "0.0.90",
"xtend": "~2.2.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion test/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test('\ncompiling block-scope with blockBinding: false', function (t) {
.transform(es6ify)
.require(__dirname + '/../example/src/features/block-scope.js', { entry: true })
.bundle(function (err, src) {
t.similar(err.message, /Unexpected token let/, 'returns error indicating that let is not supported')
t.similar(err.message, /Unexpected reserved word let while parsing file/, 'returns error indicating that let is not supported')
es6ify.traceurOverrides = null;
t.end();
});
Expand Down
15 changes: 2 additions & 13 deletions test/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,31 +43,20 @@ test('transform adds sourcemap comment and uses cache on second time', function

// Traceur converts all \s to /s so we need to do so also before comparing
var fileConverted = file.replace(/\\/g, '/');
var sourceRootConverted = path.join(path.dirname(file), path.sep).replace(/\\/g, '/');

t.deepEqual(
sourceMap
, { version: 3,
file: fileConverted,
sources: [ fileConverted, '@traceur/generated/TemplateParser/1' ],
sources: [ path.basename(fileConverted) ],
names: [],
mappings: sourceMap.mappings,
sourceRoot: sourceRootConverted,
sourcesContent: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as far as I can tell this removes all our test coverage for source maps, which was the main sticking point in previous PRs :(. We can't break that...

'module.exports = function () {\n' +
' for (let element of [1, 2, 3]) {\n' +
' console.log(\'element:\', element);\n' +
' }\n' +
'};\n',

'\n for (var $__placeholder__0 =\n' +
' $__placeholder__1[\n' +
' $traceurRuntime.toProperty(Symbol.iterator)](),\n' +
' $__placeholder__2;\n' +
' !($__placeholder__3 = $__placeholder__4.next()).done; ) {\n' +
' $__placeholder__5;\n' +
' $__placeholder__6;\n' +
' }'
'};\n'
] }
, 'adds sourcemap comment including original source'
);
Expand Down