Avoid matching sourceMappingURL inside a template string #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
changed the title
|
Patch added. All tests passing. LGTM This also removes the example comment, since this library may sometimes parse itself, resulting in false positives. |
thlorenz
reviewed
Nov 12, 2017
index.js
Outdated
| //Example (Extra space between slashes added to solve Safari bug. Exclude space in production): | ||
| // / /# sourceMappingURL=foo.js.map /*# sourceMappingURL=foo.js.map */ | ||
| return /(?:\/\/[@#][ \t]+sourceMappingURL=([^\s'"]+?)[ \t]*$)|(?:\/\*[@#][ \t]+sourceMappingURL=([^\*]+?)[ \t]*(?:\*\/){1}[ \t]*$)/mg; | ||
| return /(?:\/\/[@#][ \t]+sourceMappingURL=([^\s'"`]+?)[ \t]*$)|(?:\/\*[@#][ \t]+sourceMappingURL=([^\*]+?)[ \t]*(?:\*\/){1}[ \t]*$)/mg; | ||
| } |
There was a problem hiding this comment.
Could we please keep the comments that were there?
There was a problem hiding this comment.
How about something more like:
// Matches sourceMappingURL in either // or /* comment styles.The current comment interferes with global packages where two installations of convert-source-map end up parsing each other, causing an error to be thrown.
|
LGTM after the nit is fixed. Would like at least one more collab to have a look before merging. |
aleclarson
force-pushed
the
template-strings
branch
from
b400a9b to
38ca213
Compare
|
@aleclarson made you collaborator. Please merge to master following this guide. Thanks. |
|
@thlorenz Done 👍 |
|
Thanks published as patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof for issue #60