Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Add all disciplines #60

Merged
merged 26 commits into from
Oct 20, 2019
Merged

Add all disciplines #60

merged 26 commits into from
Oct 20, 2019

Conversation

thislooksfun
Copy link
Owner

@thislooksfun thislooksfun commented Oct 5, 2019

Implement all the disciplines.

  • Air Sailor
  • Archer
  • Beastmaster
  • Cavalryman
  • Elementalist
  • Illusionist
  • Nethermancer
  • Scout
  • Sky Raider
  • Swordsmaster
  • Thief
  • Troubadour
  • Warrior
  • Weaponsmith
  • Wizard

@thislooksfun thislooksfun added this to the v1.0.0 milestone Oct 5, 2019
@todo

This comment has been minimized.

@todo
Copy link

todo bot commented Oct 5, 2019

Implement Actions

Some disciplines grant an action that can be taken that is neither a talent or a skill, and thus needs to be treated seperately.


# TODO: Implement Actions
# BODY: Some disciplines grant an action that can be taken that is neither
# BODY: a talent or a skill, and thus needs to be treated seperately.
actions:
- name: Collaborate
action: simple


This comment was generated by todo based on a TODO comment in 0622977 in #60. cc @thislooksfun.

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   27.88%   27.93%   +0.04%     
==========================================
  Files          42       42              
  Lines         398      401       +3     
  Branches       20       20              
==========================================
+ Hits          111      112       +1     
- Misses        287      289       +2
Flag Coverage Δ
#unittests 27.93% <50%> (+0.04%) ⬆️
Impacted Files Coverage Δ
src/charDecorator/decorators/static/discipline.js 50% <50%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a76b03...0fe5181. Read the comment docs.

@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to implement this upgrade

# # TODO: Figure out how to implement this upgrade
# freeTalents:
# _other:
# One of the adept’s free Standard Matrix talents is upgraded to an
# Enhanced Matrix.
talents:


This comment was generated by todo based on a TODO comment in f90022d in #60. cc @thislooksfun.

@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to specify summon type

# TODO: Figure out how to specify summon type
- Summon [Elemental Spirits]
# TODO: Implement Actions
# BODY: Some disciplines grant an action that can be taken that is neither
# BODY: a talent or a skill, and thus needs to be treated seperately.
actions:


This comment was generated by todo based on a TODO comment in f90022d in #60. cc @thislooksfun.

@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to implement this upgrade

# # TODO: Figure out how to implement this upgrade
# freeTalents:
# _other:
# One of the adept’s free Standard Matrix talents is upgraded to an
# Enhanced Matrix.
talents:


This comment was generated by todo based on a TODO comment in f90022d in #60. cc @thislooksfun.

@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to implement this upgrade

# # TODO: Figure out how to implement this upgrade
# freeTalents:
# _other:
# One of the adept’s free Standard Matrix talents is upgraded to an
# Enhanced Matrix.
talents:


This comment was generated by todo based on a TODO comment in f90022d in #60. cc @thislooksfun.

@todo

This comment has been minimized.

@todo

This comment has been minimized.

@todo

This comment has been minimized.

@todo

This comment has been minimized.

@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to set another talent's strain to 0

# TODO: Figure out how to set another talent's strain to 0
description:
The adept no longer takes Strain when using the Aggressive Attack
Combat Option. If another effect grants them the same bonus, the adept
instead reduces the penalties by 1.


This comment was generated by todo based on a TODO comment in c9036cc in #60. cc @thislooksfun.

@todo
Copy link

todo bot commented Oct 20, 2019

Add this flavor somehow (Entertainer)

Probably just add it to the talents list


# TODO: Add this flavor somehow (Entertainer)
# BODY: Probably just add it to the talents list
#
# The adept is experienced in the ways of performing before a crowd. This
# talent works like the Entertainer skill (p. 196), but does not require
# the adept to choose a specialty.


This comment was generated by todo based on a TODO comment in c9036cc in #60. cc @thislooksfun.

@todo
Copy link

todo bot commented Oct 20, 2019

Add this flavor somehow (Craftsman)

Probably just add it to the talents list


# TODO: Add this flavor somehow (Craftsman)
# BODY: Probably just add it to the talents list
#
# This talent is similar to the Craftsman skill (p. 195), allowing the
# adept to make tests to craft and repair mundane items, including weapons
# and armor.


This comment was generated by todo based on a TODO comment in c9036cc in #60. cc @thislooksfun.

@thislooksfun thislooksfun added the ready-to-merge This PR will be merge automatically once all checks pass. label Oct 20, 2019
@thislooksfun thislooksfun changed the title [WIP] Add all disciplines Add all disciplines Oct 20, 2019
@todo
Copy link

todo bot commented Oct 20, 2019

Figure out how to set another talent's strain to 0

# TODO: Figure out how to set another talent's strain to 0
description:
The adept no longer takes Strain when using the Aggressive Attack
Combat Option. If another effect grants them the same bonus, the adept
instead reduces the penalties by 1.


This comment was generated by todo based on a TODO comment in 0fe5181 in #60. cc @thislooksfun.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge This PR will be merge automatically once all checks pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants