This repository has been archived by the owner on May 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Feature/fix e2e tests #167
Open
thislooksfun
wants to merge
11
commits into
master
Choose a base branch
from
feature/fix-e2e-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call is also buggedThis is pending nklayman/vue-cli-plugin-electron-builder#647. See #154 for more info. earthdawn/tests/e2e/electron.spec.js Lines 26 to 31 in 84c5893
This comment was generated by todo based on a
|
github-actions
bot
added
dependencies
src
Changes to any part of the source code
tests
Involving / related to any tests
tests/e2e
Involving / related to unit tests
vue
Involving / related to Vue
ci
Related to CI
labels
Feb 8, 2020
thislooksfun
force-pushed
the
feature/fix-e2e-tests
branch
from
February 8, 2020 19:00
3f2bf8a
to
71333ec
Compare
Force-pushed to fix commit names. |
Since nklayman/vue-cli-plugin-electron-builder#467 was fixed `testWithSpectron()` works again, but now `stopServe()` is broken.
thislooksfun
force-pushed
the
feature/fix-e2e-tests
branch
from
February 8, 2020 19:02
fd9e377
to
77eb111
Compare
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 21.22% 21.22%
=======================================
Files 51 51
Lines 636 636
Branches 49 49
=======================================
Hits 135 135
Misses 501 501
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending nklayman/vue-cli-plugin-electron-builder#647.
Closes #154