Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Clean up unit tests #159

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Clean up unit tests #159

merged 2 commits into from
Feb 5, 2020

Conversation

thislooksfun
Copy link
Owner

The unit tests workflow had some extra stuff in it.

The unit tests workflow has grown a bit out of its bounds, and should instead just do unit tests. Additionally, we are already usin the snyk check on PR, and also enforcing PRs to get to the master branch, so all code has to pass by snyk anyway.
As in 3162422fc5607139298f32ce8ff9a5f2a97e1eac, running prettier in here is redundant since we have restyled.io.
@thislooksfun thislooksfun added the ready-to-merge This PR will be merge automatically once all checks pass. label Feb 5, 2020
@github-actions github-actions bot added the ci Related to CI label Feb 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   21.22%   21.22%           
=======================================
  Files          51       51           
  Lines         636      636           
  Branches       49       49           
=======================================
  Hits          135      135           
  Misses        501      501
Flag Coverage Δ
#unittests 21.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e17243...034e1c3. Read the comment docs.

@mergify mergify bot merged commit 14de450 into master Feb 5, 2020
@mergify mergify bot deleted the feature/clean-up-units branch February 5, 2020 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Related to CI ready-to-merge This PR will be merge automatically once all checks pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants