Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made null handling graceful on view detachment #16

Merged
merged 1 commit into from
Mar 2, 2022
Merged

made null handling graceful on view detachment #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,3 +449,5 @@ FodyWeavers.xsd
*.tlog

# End of https://www.toptal.com/developers/gitignore/api/visualstudio,rider

.DS_Store
2 changes: 1 addition & 1 deletion Xamarin.ExoPlayerSlim.UsageChecker/Xamarin.ExoPlayerSlim.UsageChecker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
<PackageReference Include="Xamarin.Google.Android.Material" Version="1.4.0.4" />
<PackageReference Include="Xamarin.Essentials" Version="1.6.1" />
<PackageReference Include="Xamarin.ExoPlayerSlim">
<Version>2.16.1.11</Version>
<Version>2.16.1.12</Version>
</PackageReference>
</ItemGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Xamarin.ExoPlayerSlim/Xamarin.ExoPlayerSlim.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<IsPackable>true</IsPackable>
<PackageId>Xamarin.ExoPlayerSlim</PackageId>
<Version>2.16.1.11</Version>
<Version>2.16.1.12</Version>
<Description>Contains bindings for https://exoplayer.dev</Description>
<Authors>Christian Kapplmüller</Authors>
<Company>fun.music IT GmbH</Company>
Expand Down
2 changes: 1 addition & 1 deletion ...oPlayerSlim/exoplayerslim/src/main/java/com/tonestro/exoplayerslim/ExoPlayerSlimImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public void attachPlayerView(View playerView, boolean useNativeControls, int asp
@Override
public void detachPlayerView(View playerView) {
if (playerView == null) {
throw new NullPointerException("playerView must not be null");
return;
}
if (!(playerView instanceof PlayerView)) {
throw new ClassCastException("playerView is not instance of PlayerView");
Expand Down