feat: [sveltekit pod] missing issues filters #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihardz
changed the title
ihardz
changed the title
…ekit-pod-issues-missing-filters
…ekit-pod-issues-missing-filters
BigAB
suggested changes
Nov 29, 2022
svelte-kit-scss/src/lib/components/IssueSearch/IssueSearchControls/IssueSearchControls.svelte
Outdated
Show resolved
Hide resolved
| const body = await response.json(); | ||
| throw error(response.status, body?.message || response.statusText); | ||
| } | ||
| const responseBodyJson = (await response.json()) as Promise<GithubIssueMilestone[]>; |
There was a problem hiding this comment.
Generally I think casting the type with as is a code smell. Sometimes it can't be avoided, but it shouldn't be the goto solution.
I would rather see something just validate the api response is of GithubIssueMilestone type than casting it.
This does not need to be changed in this PR though, we can refactor later.
There was a problem hiding this comment.
Please suggest the change. I cannot understand how shoudl I change that
There was a problem hiding this comment.
I will add a suggestion as a future ticket
...routes/(authenticated)/[username]/[repo]/[issueSearchType=issue_search_type]/+page.server.ts
Show resolved
Hide resolved
svelte-kit-scss/src/lib/components/shared/Dropdown/DropdownMenu.svelte
Outdated
Show resolved
Hide resolved
svelte-kit-scss/src/lib/components/shared/Dropdown/DropdownMenu.svelte
Outdated
Show resolved
Hide resolved
svelte-kit-scss/src/lib/components/shared/Dropdown/DropdownMenu.svelte
Outdated
Show resolved
Hide resolved
BigAB
approved these changes
Nov 29, 2022
ihardz
added a commit
that referenced
this pull request
Nov 29, 2022
* [sveltekit-pod] Issues Search: inline filters (open/closed) * Code review fixes * Code review + Components cleanup * feat: [sveltekit pod] missing issues filters (#979) * Dinamic filters: Milestone filter. Dropdown adjustments * fix label * Milestone filter adjustments * Code review fixes * feat: [sveltekit-pod] sveltekit pod issues pulls route redirect (#998) * Dinamic filters: Milestone filter. Dropdown adjustments * fix label * Milestone filter adjustments * resolve redirect for issues search pages * adjust linked components * adjust linked components * Code review fixes * Code review * Code review * Code review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #901
Includes: