-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Disable quote retries and show fiat values #6210
[SDK] fix: Disable quote retries and show fiat values #6210
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f210a59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
e0db5b2
to
f210a59
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (8.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6210 +/- ##
==========================================
+ Coverage 56.72% 56.76% +0.03%
==========================================
Files 1161 1161
Lines 64289 64265 -24
Branches 5196 5198 +2
==========================================
+ Hits 36468 36480 +12
+ Misses 27095 27056 -39
- Partials 726 729 +3
*This pull request uses carry forward flags. Click here to find out more.
|
PR-Codex overview
This PR focuses on improving the handling of fiat transactions in the
thirdweb
package by eliminating retries on quote errors and ensuring the fiat value is displayed at every step.Detailed summary
toTokenInfo
to include a space after the formatted number.useBuyWithFiatQuote
anduseBuyWithCryptoQuote
, settingretry
tofalse
.FiatValue
component toSelectedTokenInfo
to display fiat value based on the selected token and chain.Container
gap fromxs
toxxs
inSelectedTokenInfo
.