Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] feat: Batch approvals and swaps for smart wallets #6209

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 8, 2025


PR-Codex overview

This PR introduces support for batch approvals and swaps in smart wallets, enhancing transaction efficiency and user experience.

Detailed summary

  • Added chainId to various transaction types and functions.
  • Updated SwapStatusScreen to include fromChain.
  • Incorporated batch transaction handling in SwapConfirmationScreen.
  • Adjusted logic for determining approval requirements.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 8, 2025

🦋 Changeset detected

Latest commit: 94ad3ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 10:30am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 10:30am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 10:30am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 10:30am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 10:30am

@joaquim-verges joaquim-verges marked this pull request as ready for review February 8, 2025 10:15
@joaquim-verges joaquim-verges requested review from a team as code owners February 8, 2025 10:15
@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 8, 2025
Copy link
Member Author

joaquim-verges commented Feb 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (+0.15% 🔺) 926 ms (+0.15% 🔺) 2.6 s (+1.61% 🔺) 3.5 s
thirdweb (cjs) 122.06 KB (+0.2% 🔺) 2.5 s (+0.2% 🔺) 5.1 s (+11.76% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 277 ms (-11.73% 🔽) 388 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 71 ms (+68.11% 🔺) 81 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 927 ms (+29.01% 🔺) 1.4 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant