Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix body parser code for engine webhook #6197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yash094
Copy link
Member

@Yash094 Yash094 commented Feb 7, 2025


PR-Codex overview

This PR focuses on updating the webhook handling in the application by changing the request body parsing method from text to JSON.

Detailed summary

  • Changed bodyParser.text() to bodyParser.json() for parsing incoming requests.
  • This change likely improves the handling of JSON payloads sent to the "/webhook" endpoint.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Yash094 Yash094 requested review from a team as code owners February 7, 2025 17:33
Copy link

vercel bot commented Feb 7, 2025

@Yash094 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

graphite-app bot commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.12%. Comparing base (c5dfad8) to head (8f0a128).

❗ There is a different number of reports uploaded between BASE (c5dfad8) and HEAD (8f0a128). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c5dfad8) HEAD (8f0a128)
packages 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6197       +/-   ##
===========================================
- Coverage   56.77%   42.12%   -14.65%     
===========================================
  Files        1161     1159        -2     
  Lines       64259    64146      -113     
  Branches     5197     3815     -1382     
===========================================
- Hits        36483    27023     -9460     
- Misses      27049    36422     +9373     
+ Partials      727      701       -26     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c5dfad8
packages 37.31% <ø> (-17.65%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 265 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant