Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update login script URL to HTTPS #6138

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 31, 2025

PR-Codex overview

This PR focuses on updating the script source in the script-test.html file from twl.min.js to twl.js.

Detailed summary

  • Changed the script source from <script src="http://localhost:3000/twl.min.js" data-client-id="testfoo1234"></script> to <script src="http://localhost:3000/twl.js" data-client-id="testfoo1234"></script> in apps/login/test/script-test.html.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:38am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 1, 2025 0:38am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 1, 2025 0:38am
thirdweb-www ⬜️ Skipped (Inspect) Feb 1, 2025 0:38am
wallet-ui ⬜️ Skipped (Inspect) Feb 1, 2025 0:38am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 31, 2025 23:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 23:42 Inactive
@jnsdls jnsdls marked this pull request as ready for review January 31, 2025 23:42
@jnsdls jnsdls requested review from a team as code owners January 31, 2025 23:42
Copy link
Member Author

jnsdls commented Jan 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (f4f93e6) to head (878e8ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6138      +/-   ##
==========================================
+ Coverage   56.90%   56.93%   +0.02%     
==========================================
  Files        1155     1155              
  Lines       63915    63915              
  Branches     5192     5203      +11     
==========================================
+ Hits        36372    36387      +15     
+ Misses      26816    26799      -17     
- Partials      727      729       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f4f93e6
packages 55.13% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 299 ms (+38.52% 🔺) 1.3 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 436 ms (+11.86% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 110 ms (+327.13% 🔺) 221 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 4 ms (-14.05% 🔽) 14 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 105 ms (+163.63% 🔺) 491 ms

@jnsdls jnsdls force-pushed the 01-31-update_dependencies branch from df13885 to c460b58 Compare February 1, 2025 00:08
@jnsdls jnsdls force-pushed the update_login_script_URL_to_HTTPS branch from 4054f11 to b411f8d Compare February 1, 2025 00:08
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: 878e8ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 1, 2025 00:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 1, 2025 00:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 1, 2025 00:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 1, 2025 00:08 Inactive
@jnsdls jnsdls force-pushed the update_login_script_URL_to_HTTPS branch from b411f8d to f1395ab Compare February 1, 2025 00:09
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 1, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 1, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 1, 2025 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 1, 2025 00:09 Inactive
Base automatically changed from 01-31-update_dependencies to main February 1, 2025 00:23
@jnsdls jnsdls force-pushed the update_login_script_URL_to_HTTPS branch from f1395ab to 878e8ea Compare February 1, 2025 00:25
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 1, 2025 00:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 1, 2025 00:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 1, 2025 00:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 1, 2025 00:25 Inactive
@jnsdls jnsdls merged commit b191658 into main Feb 1, 2025
27 of 29 checks passed
@jnsdls jnsdls deleted the update_login_script_URL_to_HTTPS branch February 1, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant