Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-utils] fix: use lz4js for usageV2 #6130

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 31, 2025

PR-Codex overview

This PR focuses on updating dependencies and refactoring the UsageV2Producer class to replace kafkajs-lz4 with lz4js for compression functionality, improving type usage, and making the code more modern and maintainable.

Detailed summary

  • Removed dependency on kafkajs-lz4 and added lz4js.
  • Updated import statements for kafkajs and adjusted usage of CompressionTypes.
  • Refactored UsageV2Producer to use Producer and Kafka types directly.
  • Enhanced compression methods in the init function using lz4js.
  • Added @types/lz4js as a development dependency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner January 31, 2025 03:49
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 5232c1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:22pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:22pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:22pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:22pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 6:22pm

Copy link

graphite-app bot commented Jan 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 3.77 kB types
npm/[email protected] None 0 36.4 kB johnwchadwick

View full report↗︎

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (f8ebbe5) to head (5232c1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6130      +/-   ##
==========================================
+ Coverage   56.87%   56.89%   +0.01%     
==========================================
  Files        1153     1153              
  Lines       63896    63896              
  Branches     5180     5184       +4     
==========================================
+ Hits        36344    36353       +9     
+ Misses      26825    26815      -10     
- Partials      727      728       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f8ebbe5
packages 55.08% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 1.1 s (+74.04% 🔺) 2 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.3 s (-10.97% 🔽) 3.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 206 ms (+177.62% 🔺) 318 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (+184.6% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 196 ms (+31.72% 🔺) 582 ms

@arcoraven arcoraven changed the title [service-utils] fix: use kafka-lz4-lite for usageV2 compression [service-utils] fix: use lz4js for usageV2 Jan 31, 2025
@arcoraven arcoraven merged commit 0fb586d into main Jan 31, 2025
31 of 32 checks passed
@arcoraven arcoraven deleted the ph/usageV2Imports branch January 31, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant