Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arrow function in login script #6126

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 31, 2025

PR-Codex overview

This PR introduces a self-executing function in the twl.js file, which handles user login and session management, utilizing local storage for credentials and redirecting users based on their login state.

Detailed summary

  • Added a self-executing function to manage user login.
  • Defined constants for user address and session keys.
  • Implemented logic to generate and store a unique code in local storage.
  • Handled URL parsing to extract login parameters.
  • Managed user session state and local storage cleanup.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 01:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 01:02 Inactive
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 1:06am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 31, 2025 1:06am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 31, 2025 1:06am
thirdweb-www ⬜️ Skipped (Inspect) Jan 31, 2025 1:06am
wallet-ui ⬜️ Skipped (Inspect) Jan 31, 2025 1:06am

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 38ff1f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 31, 2025 01:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 01:02 Inactive
Copy link
Member Author

jnsdls commented Jan 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review January 31, 2025 01:02
@jnsdls jnsdls requested review from a team as code owners January 31, 2025 01:02
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (60c5c26) to head (38ff1f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6126   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 60c5c26
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@jnsdls jnsdls force-pushed the fix_arrow_function_in_login_script branch from 0ecd667 to 38ff1f4 Compare January 31, 2025 01:04
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 31, 2025 01:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 01:04 Inactive
@jnsdls jnsdls merged commit 5de72c5 into main Jan 31, 2025
26 of 29 checks passed
@jnsdls jnsdls deleted the fix_arrow_function_in_login_script branch January 31, 2025 01:05
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (-0.03% 🔽) 933 ms (-0.03% 🔽) 464 ms (+96.48% 🔺) 1.4 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 724 ms (-11% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 83 ms (+50.17% 🔺) 195 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 18 ms (+271.62% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 239 ms (+295.4% 🔺) 625 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant