Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix: Remove learn more button #6109

Merged

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jan 29, 2025


PR-Codex overview

This PR focuses on simplifying the WalletAddress component by removing an unused button that linked to a blog post, thereby streamlining the code and reducing unnecessary imports.

Detailed summary

  • Removed the ExternalLinkIcon import from lucide-react.
  • Deleted a Button component that linked to a blog post.
  • The removed button had properties like variant, className, and size.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 29, 2025 23:48
Copy link

linear bot commented Jan 29, 2025

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 30, 2025 6:13am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 30, 2025 6:13am
wallet-ui ⬜️ Skipped (Inspect) Jan 30, 2025 6:13am

Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: a7fb844

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.88%. Comparing base (bf43196) to head (a7fb844).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6109   +/-   ##
=======================================
  Coverage   56.88%   56.88%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5183     5183           
=======================================
  Hits        36349    36349           
  Misses      26819    26819           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bf43196
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 863 ms (+5.68% 🔺) 1.8 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.9 s (+22.07% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 173 ms (+584.45% 🔺) 285 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (+196.25% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 308 ms (+105.89% 🔺) 694 ms

Copy link

graphite-app bot commented Jan 30, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on simplifying the `WalletAddress` component by removing the "Learn more" button and its associated link to the blog, while also cleaning up the imports by removing the unused `ExternalLinkIcon`.

### Detailed summary
- Removed the unused import of `ExternalLinkIcon` from `lucide-react`.
- Eliminated the "Learn more" button, which included:
  - The button element with `asChild`, `variant`, `className`, and `size` props.
  - The inner `<a>` element linking to the blog post.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the greg/tool-3264-remove-social-profile-learn-more-button branch from baa6890 to a7fb844 Compare January 30, 2025 06:05
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 06:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 06:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 06:05 Inactive
@graphite-app graphite-app bot merged commit a7fb844 into main Jan 30, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3264-remove-social-profile-learn-more-button branch January 30, 2025 06:14
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 30, 2025 06:14 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 30, 2025 06:14 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 30, 2025 06:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants