-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Fix: Remove learn more button #6109
[Dashboard] Fix: Remove learn more button #6109
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6109 +/- ##
=======================================
Coverage 56.88% 56.88%
=======================================
Files 1153 1153
Lines 63896 63896
Branches 5183 5183
=======================================
Hits 36349 36349
Misses 26819 26819
Partials 728 728
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on simplifying the `WalletAddress` component by removing the "Learn more" button and its associated link to the blog, while also cleaning up the imports by removing the unused `ExternalLinkIcon`. ### Detailed summary - Removed the unused import of `ExternalLinkIcon` from `lucide-react`. - Eliminated the "Learn more" button, which included: - The button element with `asChild`, `variant`, `className`, and `size` props. - The inner `<a>` element linking to the blog post. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
baa6890
to
a7fb844
Compare
PR-Codex overview
This PR focuses on simplifying the
WalletAddress
component by removing an unused button that linked to a blog post, thereby streamlining the code and reducing unnecessary imports.Detailed summary
ExternalLinkIcon
import fromlucide-react
.Button
component that linked to a blog post.variant
,className
, andsize
.