-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos in docs #3377
Fix some typos in docs #3377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CodSpeed Performance ReportMerging #3377 will improve performances by 13.75%Comparing Summary
Benchmarks breakdown
|
size-limit report 📦
|
Merge activity
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 62.89% 62.90%
=======================================
Files 861 861
Lines 63843 63843
Branches 3464 3465 +1
=======================================
+ Hits 40156 40162 +6
+ Misses 23009 23003 -6
Partials 678 678
*This pull request uses carry forward flags. Click here to find out more.
|
packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButtonProps.ts
Outdated
Show resolved
Hide resolved
<!-- start pr-codex --> ## PR-Codex overview The focus of this PR is to update variable names and improve consistency in the ConnectWallet component props. ### Detailed summary - Renamed `chainId` variable to `activeChain` for clarity - Updated `button` prop to `connectButton` for consistency - Added examples and documentation for `style` and `displayBalanceToken` props > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
5d184d2
to
7971817
Compare
PR-Codex overview
The focus of this PR is to update variable names and add examples for CSS styles in the ConnectButton component.
Detailed summary
chainId
variable toactiveChain
button
prop toconnectButton
inConnectButtonProps
style
inconnectButton
andsignInButton
options