Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in docs #3377

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix some typos in docs #3377

merged 1 commit into from
Jun 18, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Jun 18, 2024

PR-Codex overview

The focus of this PR is to update variable names and add examples for CSS styles in the ConnectButton component.

Detailed summary

  • Renamed chainId variable to activeChain
  • Updated button prop to connectButton in ConnectButtonProps
  • Added examples for style in connectButton and signInButton options

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 8:18pm

Copy link

changeset-bot bot commented Jun 18, 2024

⚠️ No Changeset found

Latest commit: 7971817

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #3377 will improve performances by 13.75%

Comparing kien/typo-temp-etc (7971817) with main (13f73ce)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main kien/typo-temp-etc Change
keccakId 1.5 ms 1.3 ms +13.75%

@kien-ngo kien-ngo marked this pull request as ready for review June 18, 2024 18:29
@kien-ngo kien-ngo requested a review from MananTank as a code owner June 18, 2024 18:29
@kien-ngo kien-ngo added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.62 KB (0%) 813 ms (0%) 3.3 s (-9.71% 🔽) 4.1 s
thirdweb (cjs) 91.93 KB (0%) 1.9 s (0%) 7 s (-5.38% 🔽) 8.8 s
thirdweb (minimal + tree-shaking) 4.74 KB (0%) 95 ms (0%) 146 ms (-81.53% 🔽) 240 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 148 ms (+22.69% 🔺) 158 ms
thirdweb/react (minimal + tree-shaking) 13.46 KB (0%) 270 ms (0%) 358 ms (+4.47% 🔺) 627 ms

Copy link

graphite-app bot commented Jun 18, 2024

Merge activity

  • Jun 18, 2:34 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 18, 4:15 PM EDT: kien-ngo added this pull request to the Graphite merge queue.
  • Jun 18, 4:18 PM EDT: kien-ngo merged this pull request with the Graphite merge queue.

Copy link

graphite-app bot commented Jun 18, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (7fdb946) to head (7971817).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   62.89%   62.90%           
=======================================
  Files         861      861           
  Lines       63843    63843           
  Branches     3464     3465    +1     
=======================================
+ Hits        40156    40162    +6     
+ Misses      23009    23003    -6     
  Partials      678      678           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from 7fdb946
packages 62.35% <100.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...rc/react/web/hooks/wallets/useActiveWalletChain.ts 88.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

<!-- start pr-codex -->

## PR-Codex overview
The focus of this PR is to update variable names and improve consistency in the ConnectWallet component props.

### Detailed summary
- Renamed `chainId` variable to `activeChain` for clarity
- Updated `button` prop to `connectButton` for consistency
- Added examples and documentation for `style` and `displayBalanceToken` props

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/typo-temp-etc branch from 5d184d2 to 7971817 Compare June 18, 2024 20:16
@graphite-app graphite-app bot merged commit 7971817 into main Jun 18, 2024
22 checks passed
@graphite-app graphite-app bot deleted the kien/typo-temp-etc branch June 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants