fix(wallets): cache walletConnectClient

[gregfromstl]

TL;DR

Implemented a caching mechanism for WalletConnect clients to improve performance and added error messaging for failed connections.

What changed?

• Introduced a caching mechanism for WalletConnect clients using a WeakMap to store instances.
• Removed redundant console.log error message in WalletConnectReceiverScreen.tsx.
• Updated disconnect message to "Disconnected".

How to test?

1. Trigger multiple WalletConnect sessions and ensure that the client is retrieved from the cache after the initial creation.
2. Test error handling by forcing a connection failure and verifying that the error message is set correctly.
3. Disconnect a WalletConnect session and ensure the disconnect message is accurate.

Why make this change?

This change enhances the performance by reducing redundant WalletConnect client creations and improves the clarity of error and disconnect messages.

---

PR-Codex overview

The focus of this PR is to optimize the WalletConnect client caching mechanism and improve error handling in the WalletConnect receiver module.

Detailed summary

• Added a caching mechanism for WalletConnect clients to improve performance.
• Updated error message handling in WalletConnect receiver.
• Improved testing setup by clearing the WalletConnect client cache before each test.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 19, 2024 2:45am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9266254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gregfromstl]

• feat(connect-wallet): support custom chains in WalletConnect #3372
• feat(wallets): add support for wallet_addEthereumChain and wallet_switchEthereumChain #3371
• fix(wallets): cache walletConnectClient #3310 👈
• refactor: update icon usage in ConnectWallet component #3309
• feat(react): Adds WalletConnect Receiver #3294
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3310 will not alter performance

_{Comparing 06-13-fix_wallets_cache_walletconnectclient (9266254) with refactor/icon-usage-connectwallet (ac5bb56)}

Summary

✅ 9 untouched benchmarks

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.65 KB (0%)	814 ms (0%)	2 s (-40.54% 🔽)	2.9 s
thirdweb (cjs)	91.92 KB (0%)	1.9 s (0%)	7 s (-7.04% 🔽)	8.9 s
thirdweb (minimal + tree-shaking)	4.74 KB (0%)	95 ms (0%)	253 ms (+135.6% 🔺)	348 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	79 ms (-67.3% 🔽)	89 ms
thirdweb/react (minimal + tree-shaking)	13.46 KB (0%)	270 ms (0%)	373 ms (-25.48% 🔽)	642 ms

[codecov]

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (ac5bb56) to head (9266254).

Additional details and impacted files

@@                        Coverage Diff                         @@
##           refactor/icon-usage-connectwallet    #3310   +/-   ##
==================================================================
  Coverage                              62.54%   62.55%           
==================================================================
  Files                                    870      870           
  Lines                                  64578    64595   +17     
  Branches                                3479     3479           
==================================================================
+ Hits                                   40390    40405   +15     
- Misses                                 23508    23510    +2     
  Partials                                 680      680           

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.60% <ø> (ø)		Carriedforward from ac5bb56
packages	61.93% <84.21%> (+<0.01%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...nectWallet/screens/WalletConnectReceiverScreen.tsx	14.10% <ø> (+0.08%)	⬆️
...rdweb/src/wallets/wallet-connect/receiver/index.ts	96.68% <84.21%> (-0.85%)	⬇️

[graphite-app]

Merge activity

• Jun 18, 8:59 PM EDT: gregfromstl added this pull request to the Graphite merge queue.
• Jun 18, 9:01 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3309.
• Jun 18, 9:01 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3309.
• Jun 18, 10:38 PM EDT: gregfromstl added this pull request to the Graphite merge queue.
• Jun 18, 10:45 PM EDT: gregfromstl merged this pull request with the Graphite merge queue.