Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Fix different APIs with same name sharing same page in references #361

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/app/references/components/TDoc/utils/getSidebarLinkgroups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
SidebarLink,
} from "../../../../../components/others/Sidebar";
import { subgroups } from "./subgroups";
import { uniqueSlugger } from "./uniqueSlugger";

const tagsToGroup = {
"@contract": "Contract",
Expand Down Expand Up @@ -120,6 +121,17 @@ function getCustomTag(doc: SomeDoc): [TagKey, string | undefined] | undefined {

export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
const linkGroups: LinkGroup[] = [];
const generatedLinks = new Set<string>();

const getLink = (href: string) => {
const link = uniqueSlugger({
base: href,
isUnique: (s) => !generatedLinks.has(s),
});

generatedLinks.add(link);
return link;
};

// group links by tags
function createSubGroups(key: keyof typeof subgroups, docs: SomeDoc[]) {
Expand Down Expand Up @@ -155,7 +167,7 @@ export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
([extensionName, docs]) => {
const links = docs.map((d) => ({
name: d.name,
href: `${path}/${extensionName.toLowerCase()}/${d.name}`,
href: getLink(`${path}/${extensionName.toLowerCase()}/${d.name}`),
}));
return {
name: extensionName,
Expand All @@ -166,7 +178,7 @@ export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
if (!linkGroups.find((group) => group.name === name)) {
linkGroups.push({
name: name,
href: `${path}/${key}`,
href: getLink(`${path}/${key}`),
links: [{ name: "Extensions", links: extensionLinkGroups }],
});
} else {
Expand Down Expand Up @@ -224,7 +236,7 @@ export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
name: tagsToGroup[tag],
links: groupDocs.map((d) => ({
name: d.name,
href: `${path}/${d.name}`,
href: getLink(`${path}/${d.name}`),
})),
});
};
Expand All @@ -236,7 +248,7 @@ export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
ungroupedLinks.forEach((d) => {
links.push({
name: d.name,
href: `${path}/${d.name}`,
href: getLink(`${path}/${d.name}`),
});
});

Expand All @@ -251,7 +263,7 @@ export function getSidebarLinkGroups(doc: TransformedDoc, path: string) {
linkGroups.push({
name: name,
links: links,
href: `${path}/${key}`,
href: getLink(`${path}/${key}`),
});
}
}
Expand Down
40 changes: 13 additions & 27 deletions src/app/references/components/TDoc/utils/slugs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,10 @@ import { SomeDoc } from "@/app/references/components/TDoc/types";
import { TransformedDoc } from "typedoc-better-json";
import { getExtensionName } from "./getSidebarLinkgroups";
import { subgroups } from "./subgroups";
import { uniqueSlugger } from "./uniqueSlugger";

export function fetchAllSlugs(doc: TransformedDoc) {
const names: string[] = [];

for (const key in doc) {
const value = doc[key as keyof TransformedDoc];
if (Array.isArray(value)) {
value.forEach((v) => {
if (v.kind === "function") {
const extensionBlockTag = v.signatures
?.find((s) => s.blockTags?.some((tag) => tag.tag === "@extension"))
?.blockTags?.find((tag) => tag.tag === "@extension");

if (extensionBlockTag) {
const extensionName = getExtensionName(extensionBlockTag);
if (extensionName) {
names.push(`${extensionName.toLowerCase()}/${v.name}`);
// skip to next loop
return;
}
}
}

names.push(v.name);
});
}
}
const names = Object.keys(getSlugToDocMap(doc));

// add slugs for category pages
for (const _key in subgroups) {
Expand All @@ -44,6 +21,13 @@ export function fetchAllSlugs(doc: TransformedDoc) {
export function getSlugToDocMap(doc: TransformedDoc) {
const slugToDocMap: Record<string, SomeDoc> = {};

const ensureUniqueSlug = (slug: string) => {
return uniqueSlugger({
base: slug,
isUnique: (s) => !(s in slugToDocMap),
});
};

for (const key in doc) {
const value = doc[key as keyof TransformedDoc];
if (Array.isArray(value)) {
Expand All @@ -58,13 +42,15 @@ export function getSlugToDocMap(doc: TransformedDoc) {
if (extensionName) {
const name = `${extensionName.toLowerCase()}/${v.name}`;

slugToDocMap[name] = v;
slugToDocMap[ensureUniqueSlug(name)] = v;

// skip to next loop
return;
}
}
}
slugToDocMap[v.name] = v;

slugToDocMap[ensureUniqueSlug(v.name)] = v;
});
}
}
Expand Down
23 changes: 23 additions & 0 deletions src/app/references/components/TDoc/utils/uniqueSlugger.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
export function uniqueSlugger(options: {
base: string;
isUnique: (slug: string) => boolean;
}) {
const limit = 10;
const { base, isUnique } = options;

// if slug is unique, save it and return
if (isUnique(base)) {
return base;
}

// build a new slug by adding -n where n is the first number that makes the slug unique
let i = 2;
while (!isUnique(`${base}-${i}`)) {
i++;
if (i > limit) {
throw new Error(`Too many duplicates found for slug: ${base}`);
}
}

return `${base}-${i}`;
}
Loading