Address #931 and similar issue when parsing times #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All_number_words is not working perfectly here. The number words need to go through localization and also need word boundaries, otherwise they match other partial ingredients or time words in other languages. E.g., "ten" match the tail of the German word for minutes (Minuten). Disable broken parsing of number words for now. Fixes thinkle#931. Signed-off-by: Martin Pohlack <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All_number_words is not working perfectly here. The number words need
to go through localization and also need word boundaries, otherwise
they match other partial ingredients or time words in other languages.
E.g., "ten" match the tail of the German word for minutes (Minuten).
Disable broken parsing of number words for now.
Fixes #931.
Signed-off-by: Martin Pohlack [email protected]