[tr064] log warning if config invalid (openhab#9529)

Signed-off-by: Jan N. Klug <[email protected]>
thinkingstone · Nov 7, 2021 · 335e720 · 335e720
1 parent ff2b73d
commit 335e720
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/....tr064/src/main/java/org/openhab/binding/tr064/internal/config/Tr064SubConfiguration.java b/....tr064/src/main/java/org/openhab/binding/tr064/internal/config/Tr064SubConfiguration.java
@@ -12,7 +12,6 @@
  */
 package org.openhab.binding.tr064.internal.config;
 
-import java.util.Collections;
 import java.util.List;
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
@@ -27,7 +26,7 @@ public class Tr064SubConfiguration extends Tr064BaseThingConfiguration {
     public String uuid = "";
 
     // Lan Device
-    public List<String> macOnline = Collections.emptyList();
+    public List<String> macOnline = List.of();
 
     public boolean isValid() {
         return !uuid.isEmpty();

diff --git a/...org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java b/...org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java
@@ -259,7 +259,15 @@ private static Set<String> getAndCheckParameters(String channelId, ActionType ac
             // validate parameter against pattern
             String parameterPattern = parameter.getPattern();
             if (parameterPattern != null) {
-                parameters.removeIf(param -> !param.matches(parameterPattern));
+                parameters.removeIf(param -> {
+                    if (!param.matches(parameterPattern)) {
+                        LOGGER.warn("Removing {} while processing {}, does not match pattern {}, check config.", param,
+                                channelId, parameterPattern);
+                        return true;
+                    } else {
+                        return false;
+                    }
+                });
             }
 
             // validate parameter against SCPD (if not internal only)