[surepetcare] Check for null before updating pet location channels (o…

…penhab#11235) fixes openhab#11234 Signed-off-by: Maarten Blokker <[email protected]>
thinkingstone · Nov 7, 2021 · 30a77db · 30a77db
1 parent 7c34ffb
commit 30a77db
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/...src/main/java/org/openhab/binding/surepetcare/internal/handler/SurePetcarePetHandler.java b/...src/main/java/org/openhab/binding/surepetcare/internal/handler/SurePetcarePetHandler.java
@@ -164,6 +164,21 @@ protected void updateThing() {
                     if (loc.since != null) {
                         updateState(PET_CHANNEL_LOCATION_CHANGED, new DateTimeType(loc.since));
                     }
+
+                    if (loc.deviceId != null) {
+                        SurePetcareDevice device = petcareAPI.getDevice(loc.deviceId.toString());
+                        if (device != null) {
+                            updateState(PET_CHANNEL_LOCATION_CHANGED_THROUGH, new StringType(device.name));
+                        }
+                    } else if (loc.userId != null) {
+                        SurePetcareHousehold household = petcareAPI.getHousehold(pet.householdId.toString());
+                        if (household != null) {
+                            Long userId = loc.userId;
+                            household.users.stream().map(user -> user.user).filter(user -> userId.equals(user.userId))
+                                    .forEach(user -> updateState(PET_CHANNEL_LOCATION_CHANGED_THROUGH,
+                                            new StringType(user.userName)));
+                        }
+                    }
                 }
                 updateState(PET_CHANNEL_DATE_OF_BIRTH, pet.dateOfBirth == null ? UnDefType.UNDEF
                         : new DateTimeType(pet.dateOfBirth.atStartOfDay(ZoneId.systemDefault())));
@@ -175,20 +190,6 @@ protected void updateThing() {
                         updateState(PET_CHANNEL_TAG_IDENTIFIER, new StringType(tag.tag));
                     }
                 }
-                if (pet.status.activity.deviceId != null) {
-                    SurePetcareDevice device = petcareAPI.getDevice(pet.status.activity.deviceId.toString());
-                    if (device != null) {
-                        updateState(PET_CHANNEL_LOCATION_CHANGED_THROUGH, new StringType(device.name));
-                    }
-                } else if (pet.status.activity.userId != null) {
-                    SurePetcareHousehold household = petcareAPI.getHousehold(pet.householdId.toString());
-                    if (household != null) {
-                        Long userId = pet.status.activity.userId;
-                        household.users.stream().map(user -> user.user).filter(user -> userId.equals(user.userId))
-                                .forEach(user -> updateState(PET_CHANNEL_LOCATION_CHANGED_THROUGH,
-                                        new StringType(user.userName)));
-                    }
-                }
                 SurePetcarePetFeeding feeding = pet.status.feeding;
                 if (feeding != null) {
                     SurePetcareDevice device = petcareAPI.getDevice(feeding.deviceId.toString());