Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return entity metadata in delete REST API response #3390

Merged

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Feb 11, 2025

Proposed changes

Fixes:

  • Entity store DELETE API to return full entity metadata of deleted entities
  • Return HTTP 204 when deleting non-existent entity

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/common/mqtt_channel/src/topics.rs 0.00% 3 Missing ⚠️
...ates/core/tedge_agent/src/entity_manager/server.rs 75.00% 1 Missing ⚠️
crates/core/tedge_api/src/entity_store.rs 90.90% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
585 0 3 585 100 1h31m31.570279999s

@albinsuresh albinsuresh marked this pull request as ready for review February 11, 2025 08:46
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added the theme:entity_store Entity store related functionality label Feb 11, 2025
@reubenmiller reubenmiller changed the title Return entity metadata in delete REST API response feat: Return entity metadata in delete REST API response Feb 11, 2025
@reubenmiller reubenmiller added the skip-release-notes Don't include the ticket in the auto generated release notes label Feb 11, 2025
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm my approval

@albinsuresh albinsuresh force-pushed the imp/entity-delete-rest-api-updates branch from c44b3ad to a98d06d Compare February 13, 2025 19:28
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@albinsuresh albinsuresh added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@albinsuresh albinsuresh added this pull request to the merge queue Feb 14, 2025
Merged via the queue into thin-edge:main with commit 0fe27a1 Feb 14, 2025
33 checks passed
@albinsuresh albinsuresh deleted the imp/entity-delete-rest-api-updates branch February 14, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Don't include the ticket in the auto generated release notes theme:entity_store Entity store related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants