-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Added a helm chart with some basic doc; #94
Conversation
@Filipe-Souza thank you so much for taking the time to create this PR! I am not able to test this PR today, but I will definitely do so tomorrow! |
- Added parameters to include a external PVC;
Beat me to it, well done |
@Twinki14 Would you mind reviewing this? I do not have a Kubernetes cluster available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdownlint found some warnings
Updated the README with the lint specs |
Apologies for being late to this, work has kept me insanely busy This all looked pretty good to me, I liked the way the helm chart was setup, specifically having some good initial values for resource limits/requests & the way the overall chart has been laid out Also, you can spin up a local k8s cluster in latest docker-desktop versions! https://docs.docker.com/desktop/kubernetes/ It's incredibly helpful and makes testing stuff like this very easy |
- Added a helm chart with some basic doc;
Context
Choices
Test instructions
Checklist before requesting a review