Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added a helm chart with some basic doc; #94

Merged
merged 11 commits into from
Jan 25, 2024
Merged

- Added a helm chart with some basic doc; #94

merged 11 commits into from
Jan 25, 2024

Conversation

Filipe-Souza
Copy link
Contributor

@Filipe-Souza Filipe-Souza commented Jan 24, 2024

Context

  • Adds a helm chart to the project.

Choices

  • Basically I use ArgoCD to deploy most of the projects and since I already developed the chart to my own use, I wanted to share it.

Test instructions

  1. Git clone the repo;
  2. Install Helm client and check if you have access to a Kubernetes cluster (tested on v1.29);
  3. Create your values.override.yaml file and add the properties that are pertinent to your cluster;
  4. Run the following command:
  5. helm install --create-namespace --namespace palworld palworld chart/ --values values.override.yaml

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef added enhancement New feature or request kubernetes Issue/PR related to Kubernetes labels Jan 24, 2024
@thijsvanloef
Copy link
Owner

@Filipe-Souza thank you so much for taking the time to create this PR! I am not able to test this PR today, but I will definitely do so tomorrow!

@Twinki14
Copy link
Contributor

Beat me to it, well done

@thijsvanloef
Copy link
Owner

@Twinki14 Would you mind reviewing this? I do not have a Kubernetes cluster available

Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint found some warnings

@Filipe-Souza
Copy link
Contributor Author

Updated the README with the lint specs

@thijsvanloef thijsvanloef self-requested a review January 25, 2024 12:42
@thijsvanloef thijsvanloef merged commit 61b0529 into thijsvanloef:main Jan 25, 2024
4 checks passed
@Twinki14
Copy link
Contributor

Twinki14 commented Jan 25, 2024

@Twinki14 Would you mind reviewing this? I do not have a Kubernetes cluster available

Apologies for being late to this, work has kept me insanely busy

This all looked pretty good to me, I liked the way the helm chart was setup, specifically having some good initial values for resource limits/requests & the way the overall chart has been laid out

Also, you can spin up a local k8s cluster in latest docker-desktop versions! https://docs.docker.com/desktop/kubernetes/ It's incredibly helpful and makes testing stuff like this very easy

MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
- Added a helm chart with some basic doc;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kubernetes Issue/PR related to Kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants