Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discord old backup remove message to include old_backup_days #503

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

makotsuba
Copy link
Contributor

@makotsuba makotsuba commented Mar 11, 2024

Fix Discord old backup remove message to include old_backup_days.

Context

Issue #501 that I drafted was modified by #502.
The message is now sent, but old_backup_days is broken.
So I fixed it.

Choices

To apply old_backup_message (e.g. 30).

Test instructions

  1. I built my own image with the code changes and ran the backup command on it to see the messages sent to Discord.

Before fix
スクリーンショット 2024-03-11 094329

After fix
スクリーンショット 2024-03-11 094402

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • I've added documentation about this change to the docs.
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

Fix Discord messages to include old_backup_days.
@makotsuba makotsuba force-pushed the fix-discord-messages branch from 631ddff to 5523060 Compare March 11, 2024 00:38
@thijsvanloef thijsvanloef merged commit e5f0213 into thijsvanloef:main Mar 12, 2024
10 checks passed
@makotsuba makotsuba deleted the fix-discord-messages branch March 12, 2024 16:24
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Fix Discord old backup remove message to include old_backup_days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants