-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better compatibility for ARM64 hosts #464
Better compatibility for ARM64 hosts #464
Conversation
@Zarrsito do you mind testing this for me? i don't have a machine that can recreate your problem |
Sure! :D But what exactly do i need to do to test this ? when i try to pull the image with container station i get a choice what brand i want to download, do i have to select some special ? I´ve now already tryed to download the dev-arm64 version, which is sending me into a 4k page size error (i had that problem with the latest version too, until i found the latest-arm64 version) |
@Zarrsito you can use the following image: |
ive tested the above build and im getting this error ; usermod: no changes QNAP changed page size to 64k |
@Zarrsito if you pull |
so i´ve tested, and this is the result: EXECUTING USERMOD do i need some special folders as workingspace for this ? |
@Zarrsito Okay, I didn't realize you were not using the latest tag when you submitted the issue. This fix is meant for those with CPUs that are only capable of executing ARM64 binaries without an additional compatibility layer (mostly those who are not running Docker Desktop) which I believe is the problem for those in issue #366. I thought you had the same issue. I'll revert the page size check change as it was the expected behaviour. |
what do u mean with latest tag? =) i´ve answered the questions as good as possible :) thijsvanloef/palworld-server-docker:pr-464 |
Don't worry about it. Your answers were perfect. It was just a misunderstanding on my part. This specific fix is not for your problem. If using the |
@sonroyaalmerol I can't really test this PR, are you confident that it has been tested enough? |
I can say that this PR will not affect existing ARM64 users. It's more of adding a different option for people to try if they had an ARM64 host that didn't work previously. It shouldn't have any breaking changes. |
…ility-mode Better compatibility for ARM64 hosts
Context
Choices
Test instructions
Checklist before requesting a review