Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot cron job #260

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Conversation

Dashboy1998
Copy link
Contributor

Context

Choices

  • Already using cron for automatic updates and backups

Test instructions

  1. Enable rcon & auto reboots
  2. Set the reboot expression near your current time so you don't wait long
  3. Start the container
  4. Join the game and wait for the reboot

image

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

README.md Outdated Show resolved Hide resolved
@Technetium1
Copy link

Could be nice to add in https://github.com/thijsvanloef/palworld-server-docker/blob/main/.env.example

@MSpreckels
Copy link
Contributor

Dont we already have a reboot cronjob? #206

@Dashboy1998
Copy link
Contributor Author

Dont we already have a reboot cronjob? #206

That appears to be specifically for Kubernetes whereas this will work for the stand alone container.

@MSpreckels
Copy link
Contributor

You are correct. Does it make sense to keep the k8s only variant of a daily reboot when it will be implemented in the container?

@Dashboy1998
Copy link
Contributor Author

You are correct. Does it make sense to keep the k8s only variant of a daily reboot when it will be implemented in the container?

I think the k8s version has some specific benefits for k8s. I don't use k8s so I'm not really sure of the benefits of having a separate solution for them.

Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thijsvanloef thijsvanloef merged commit 4ed1fca into thijsvanloef:main Feb 2, 2024
4 checks passed
@Technetium1
Copy link

@MSpreckels keeping both makes sense to me because they are not restarting exactly the same way. There's more granularity available with the Kubernetes spec, such as killing the job if it times out, and the fact that prevents concurrent jobs from executing at once, but the same effect is unnecessary with only 1 Docker container. Even moreso because there's potential for that job to run on multiple replicas in a cluster (even if they don't exist right now); with offset times, or just waiting for completion on each replica.

Worth noting that AUTO_REBOOT_ENABLED=false to prevent issue for k8s users.

MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants