-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reboot cron job #260
Reboot cron job #260
Conversation
Could be nice to add in https://github.com/thijsvanloef/palworld-server-docker/blob/main/.env.example |
Dont we already have a reboot cronjob? #206 |
That appears to be specifically for Kubernetes whereas this will work for the stand alone container. |
You are correct. Does it make sense to keep the k8s only variant of a daily reboot when it will be implemented in the container? |
I think the k8s version has some specific benefits for k8s. I don't use k8s so I'm not really sure of the benefits of having a separate solution for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MSpreckels keeping both makes sense to me because they are not restarting exactly the same way. There's more granularity available with the Kubernetes spec, such as killing the job if it times out, and the fact that prevents concurrent jobs from executing at once, but the same effect is unnecessary with only 1 Docker container. Even moreso because there's potential for that job to run on multiple replicas in a cluster (even if they don't exist right now); with offset times, or just waiting for completion on each replica. Worth noting that |
Reboot cron job
Context
Choices
Test instructions
Checklist before requesting a review