Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Modified the chart, now the healthz container/service port is optional #162

Merged
merged 2 commits into from
Jan 28, 2024
Merged

- Modified the chart, now the healthz container/service port is optional #162

merged 2 commits into from
Jan 28, 2024

Conversation

Filipe-Souza
Copy link
Contributor

Context

  • Now deploying the healthz container and service port is optional;

Choices

  • To avoid conflicts with multiples cloud providers and different load balancers provisioning/types

Test instructions

  1. Git clone the repo;
  2. Install Helm client and check if you have access to a Kubernetes cluster (tested on v1.29);
  3. Create your values.override.yaml file and add the properties that are pertinent to your cluster;
  4. Run the following command:
  5. helm install --create-namespace --namespace palworld palworld chart/ --values values.override.yaml
  6. The healthz container should not be created by default, the service should not have a 80/tcp port mapped

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

Twinki14

This comment was marked as outdated.

@thijsvanloef
Copy link
Owner

please ignore linting errors on SECURITY and CODE OF CONDUCT, change have already been made on the main branch

@Filipe-Souza Filipe-Souza marked this pull request as ready for review January 28, 2024 05:32
@thijsvanloef
Copy link
Owner

@Filipe-Souza Is this PR ready for merge?

@Filipe-Souza
Copy link
Contributor Author

Screenshot 2024-01-28 120529
The default deployment option does not deploy the healthz container

@thijsvanloef thijsvanloef merged commit 56b2192 into thijsvanloef:main Jan 28, 2024
3 of 4 checks passed
@Filipe-Souza Filipe-Souza deleted the optional-healthz-container branch January 28, 2024 18:14
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…z-container

- Modified the chart, now the healthz container/service port is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants