Make volume mount hierarchy consistent, implement tickrate #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsvanloef
added
help wanted
|
@hemsleyk Thanks for the PR, I do not have a kubernetes cluster so I marked it "help wanted" hopefully someone else is able to review! |
Twinki14
approved these changes
Jan 27, 2024
The kubernetes side of these changes looks good to me |
|
might not work because of how yaml is translating the spaces. Testing.. |
MusclePr
pushed a commit
to MusclePr/palworld-server-docker
that referenced
this pull request
Jun 19, 2024
Make volume mount hierarchy consistent, implement tickrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For me, volume mount was not updating despite destroying the pod and spawning a new one.
Changing the hierarchy to be consistent with the data dir mount fixed this when redeploying despite k8s claiming the yaml was equivalent.
My goal was to implement changes to the tickrate. This exposes tickrate as a setting.
Choices
Resolved my issue. Server subjectively seems more active.
Test instructions
kubectl exec -- cat /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini
Before: default contents despite configmap looking correct
After: reflects custom configmap with tickrate change
Checklist before requesting a review