Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error subspecification #15

Merged
merged 2 commits into from
Sep 15, 2024
Merged

feat: error subspecification #15

merged 2 commits into from
Sep 15, 2024

Conversation

thijsmie
Copy link
Owner

Checklist

  • I have read the Contribution Guidelines
  • I have read and agree to the Code of Conduct
  • I have read and agree that my contributions will be included under the project license
  • I have added a description of my changes and why I want them or linked the relevant pull request below
  • I have ran the formatter, linter and tests locally and ensured they give their all green
  • If contributing new code: I've ensured my new code is covered sufficiently by unit and integration tests

Description of Changes

Adds different errors per category

Related Issues

Fixes #12

@thijsmie thijsmie merged commit 70fe815 into main Sep 15, 2024
4 checks passed
@thijsmie thijsmie deleted the feat-errors branch September 15, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paillat-dev Paillat-dev Paillat-dev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Subclass PocketbaseError more to have more granular error catching capabilityes
2 participants
@thijsmie @Paillat-dev