Fix redirect with basepath

Fix sveltejs#589
thgh · Mar 3, 2019 · 13b64cd · 13b64cd
1 parent 9522cb4
commit 13b64cd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/runtime/src/server/middleware/get_page_handler.ts b/runtime/src/server/middleware/get_page_handler.ts
@@ -177,7 +177,7 @@ export function get_page_handler(
 
 		try {
 			if (redirect) {
-				const location = URL.resolve(req.baseUrl || '/', redirect.location);
+				const location = URL.resolve((req.baseUrl || '') + '/', redirect.location);
 
 				res.statusCode = redirect.statusCode;
 				res.setHeader('Location', location);

diff --git a/test/apps/with-basepath/test.ts b/test/apps/with-basepath/test.ts
@@ -13,6 +13,7 @@ describe('with-basepath', function() {
 	let page: puppeteer.Page;
 	let base: string;
 
+	// helpers
 	let start: () => Promise<void>;
 	let prefetchRoutes: () => Promise<void>;
 	let title: () => Promise<string>;
@@ -63,14 +64,13 @@ describe('with-basepath', function() {
 			'custom-basepath/global.css',
 			'custom-basepath/index.html',
 			'custom-basepath/redirect-from/index.html',
-			'custom-basepath/redirect-to',
+			'custom-basepath/redirect-to/index.html',
 			'custom-basepath/service-worker-index.html',
 			'custom-basepath/service-worker.js'
 		]);
 	});
 
 	it('redirects on server', async () => {
-		console.log('base', base)
 		await page.goto(`${base}/custom-basepath/redirect-from`);
 
 		assert.equal(