Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump css-loader from 2.1.1 to 3.0.0 in /WcaOnRails #4225

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 17, 2019

Bumps css-loader from 2.1.1 to 3.0.0.

Release notes

Sourced from css-loader's releases.

v3.0.0

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option
Changelog

Sourced from css-loader's changelog.

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.0.0 branch from 478fc22 to 0d69e48 Compare June 19, 2019 17:59
@viroulep
Copy link
Contributor

I investigate that a bit and the error is not related to the warning showing up in Travis, I believe.
Some options were removed from css-loader, which checks their usage.
In the webpack dev server I've got errors like:

ERROR in ./app/javascript/markdown-editor/style.scss (./node_modules/css-loader/dist/cjs.js??ref--7-1!./node_modules/postcss-loader/src??ref--7-2!./node_modules/sass-loader/lib/loader.js??ref--7-3!./app/javascript/markdown-editor/style.scss)
    Module build failed (from ./node_modules/css-loader/dist/cjs.js):
    ValidationError: CSS Loader Invalid Options
    
    options should NOT have additional properties

unfortunately I don't have quite the time to dig deeper, but it's probably one of the modules which uses a now illegal option :(
(I didn't find an occurrence of us using directly css-loader)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.0.0 branch from 0d69e48 to 3a9f212 Compare July 9, 2019 22:59
@dependabot-preview
Copy link
Contributor Author

Superseded by #4346.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.0.0 branch July 22, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant