Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require entry fees for competitions in multiple countries. #3755

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Dec 29, 2018

This just came up for FMC Europe, a competition which has different
registration requirements per venue. Rather than requiring the user to
specify an inaccurate number, we'd rather have these values be NULL
(unknown) in our database.

Note: This does not detect competitions in multiple venues within the
same country (such as FMC USA). We can add support for that later if we
decide we want to.

@jfly jfly requested a review from AlbertoPdRF December 29, 2018 22:02
Copy link
Contributor

@AlbertoPdRF AlbertoPdRF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question! By the way, should we add this possibility for other requirements too?

WcaOnRails/app/models/competition.rb Outdated Show resolved Hide resolved
@jfly jfly force-pushed the do-not-require-entry-fees-for-competitions-in-multiple-countries branch from f92e3e5 to d91b65c Compare December 29, 2018 22:38
This just came up for FMC Europe, a competition which has different
registration requirements per venue. Rather than requiring the user to
specify an inaccurate number, we'd rather have these values be NULL
(unknown) in our database.

Note: This does not detect competitions in multiple venues within the
same country (such as FMC USA). We can add support for that later if we
decide we want to.
@jfly jfly force-pushed the do-not-require-entry-fees-for-competitions-in-multiple-countries branch from d91b65c to 1c2fbac Compare December 29, 2018 23:40
@jfly jfly merged commit 66048f3 into thewca:master Dec 29, 2018
@jfly jfly deleted the do-not-require-entry-fees-for-competitions-in-multiple-countries branch December 29, 2018 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants