Remove duplicate serialization tests from test_api #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking at how can we simplify or split test_api.py when I noticed that the test cases covered by those two test functions are already covered in the test_metadata_serialization.py module in the "invalid_keys" and "invalid_roles" datasets. Signed-off-by: Martin Vrachev <[email protected]>
4 tasks
jku
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1414
Description of the changes being introduced by the pull request:
I was looking at how can we simplify or split
test_api.pywhen I noticedthat the test cases covered by those two test functions are already
covered in the
test_metadata_serialization.pymodule with the"invalid_keys" and "invalid_roles" datasets.
invalid_keys: https://github.com/theupdateframework/tuf/blob/e242a750d4d17e7649b65333ce8e073c7d7ae839/tests/test_metadata_serialization.py#L109invalid_roles:https://github.com/theupdateframework/tuf/blob/e242a750d4d17e7649b65333ce8e073c7d7ae839/tests/test_metadata_serialization.py#L127
Signed-off-by: Martin Vrachev [email protected]
Please verify and check that the pull request fulfills the following
requirements: