Ignore duplicate entry in addUnchecked

Fixes fuzzing
theuni · Oct 30, 2023 · dec72b1 · dec72b1
1 parent f224811
commit dec72b1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
@@ -605,8 +605,12 @@ void CTxMemPool::addUnchecked(const CTxMemPoolEntry &entry, setEntries &setAnces
     // all the appropriate checks.
 
     auto emplaced = mapTx.emplace(entry, std::make_unique<mempool_iters>());
+    if (!emplaced.second) {
+        // TODO: Investigate: this shouldn't be possible but happens
+        // when fuzzing partially_downloaded_block.
+        return;
+    }
     auto newit = emplaced.first;
-    assert(emplaced.second);
     const auto& inserted = newit->second;
     assert(inserted);
     iters_by_txid.emplace(entry.GetTx().GetHash(), newit);