rpc: avoid copying UniValue keys when possible

theuni · May 13, 2024 · 9bd23b5 · 9bd23b5
1 parent d63cfed
commit 9bd23b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -2011,13 +2011,14 @@ static RPCHelpMan getblockstats()
     }
 
     UniValue ret(UniValue::VOBJ);
-    for (const std::string& stat : stats) {
+    for (auto it = stats.begin(); it != stats.end(); ++it) {
+        std::string& stat = stats.extract(it).value();
         const UniValue& value = ret_all[stat];
         if (value.isNull()) {
             throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Invalid selected statistic '%s'", stat));
         }
         // TODO
-        ret.pushKV(stat, value);
+        ret.pushKV(std::move(stat), value);
     }
     return ret;
 },

diff --git a/src/wallet/rpc/addresses.cpp b/src/wallet/rpc/addresses.cpp
@@ -689,7 +689,7 @@ RPCHelpMan getaddressesbylabel()
             // which currently is O(1).
             UniValue value(UniValue::VOBJ);
             value.pushKV("purpose", _purpose ? PurposeToString(*_purpose) : "unknown");
-            ret.pushKVEnd(address, std::move(value));
+            ret.pushKVEnd(std::move(address), std::move(value));
         }
     });