Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient ammo refill & auto-silence implementation #3

Closed
thetredev opened this issue Dec 1, 2017 · 2 comments
Closed

Inefficient ammo refill & auto-silence implementation #3

thetredev opened this issue Dec 1, 2017 · 2 comments
Labels
enhancement

Comments

@thetredev
Copy link
Owner

Due to the fact that I didn't know better, the current implementation of ammo refill & auto-silence weapons could potentially cause lags and poor responsiveness in a 'real world' public server.

Do not use the plugin until I figure out a way to improve the plugin's performance!
@thetredev
Copy link
Owner Author

See https://forums.sourcepython.com/viewtopic.php?f=20&t=1653

thetredev pushed a commit that referenced this issue Dec 3, 2017
Fix issue #3
23afa4c 
Ammo Refill:
  Replace ammo refill logic with setting ammo_ cvars to -2
  during gameplay. -2 means 999 - this is applied to all
  ammo types except utilities.

  See the following Source.Python forums thread for more details:
  https://forums.sourcepython.com/viewtopic.php?f=20&t=1653

Silencer Options for Inventory Items:
  Use an EntityPreHook for weapon entities which can be silenced
  instead of a OnPlayerRunCommand listener.

Signed-off-by: BackRaw <[email protected]>
thetredev pushed a commit that referenced this issue Dec 3, 2017
Fix issue #3
ec5e682 
Ammo Refill:
  Replace ammo refill logic with setting ammo_ cvars to -2
  during gameplay. -2 means 999 - this is applied to all
  ammo types except utilities.

  See the following Source.Python forums thread for more details:
  https://forums.sourcepython.com/viewtopic.php?f=20&t=1653

Silencer Options for Inventory Items:
  Use an EntityPreHook for weapon entities which can be silenced
  instead of a OnPlayerRunCommand listener.

Signed-off-by: BackRaw <[email protected]>
@thetredev
Copy link
Owner Author

23afa4c was lacking management of the ammo_556mm_max cvar, ec5e682 fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thetredev