Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug where having no data context would break sharing #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions client/views/facebook/facebook.coffee
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
Template.shareit_facebook.rendered = ->
return unless @data

@autorun ->
template = Template.instance()
data = Template.currentData()
template = Template.instance()
data = Template.currentData() || ShareIt.defaultDataContext()

$('meta[property^="og:"]').remove()
#
# OpenGraph tags
Expand All @@ -17,7 +15,7 @@ Template.shareit_facebook.rendered = ->
$('<meta>', { property: 'og:url', content: url }).appendTo 'head'
$('<meta>', { property: 'og:title', content: title }).appendTo 'head'
$('<meta>', { property: 'og:description', content: description }).appendTo 'head'

if data.thumbnail
if typeof data.thumbnail == "function"
img = data.thumbnail()
Expand All @@ -26,9 +24,9 @@ Template.shareit_facebook.rendered = ->
if img
if not /^http(s?):\/\/+/.test(img)
img = location.origin + img

$('<meta>', { property: 'og:image', content: img }).appendTo 'head'

if ShareIt.settings.sites.facebook.appId?
template.$('.fb-share').click (e) ->
e.preventDefault()
Expand All @@ -45,9 +43,9 @@ Template.shareit_facebook.rendered = ->
href = base + "?s=100&p[url]=" + url + "&p[title]=" + title + "&p[summary]=" + summary
if img
href += "&p[images][0]=" + encodeURIComponent img

template.$(".fb-share").attr "href", href

return

Template.shareit_facebook.helpers(ShareIt.helpers)
12 changes: 5 additions & 7 deletions client/views/googleplus/googleplus.coffee
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
Template.shareit_googleplus.rendered = () ->
return unless @data

@autorun ->
template = Template.instance()
data = Template.currentData()
data = Template.currentData() || ShareIt.defaultDataContext()
$('meta[itemscope]').remove()

#
# Schema tags
#
Expand All @@ -17,7 +15,7 @@ Template.shareit_googleplus.rendered = () ->
$('<meta>', { itemprop: 'name', content: location.hostname }).appendTo 'head'
$('<meta>', { itemprop: 'url', content: url }).appendTo 'head'
$('<meta>', { itemprop: 'description', content: description }).appendTo 'head'

if data.thumbnail
if typeof data.thumbnail == "function"
img = data.thumbnail()
Expand All @@ -26,12 +24,12 @@ Template.shareit_googleplus.rendered = () ->
if img
if not /^http(s?):\/\/+/.test(img)
img = location.origin + img

$('<meta>', { itemprop: 'image', content: img }).appendTo 'head'
#
# Google share button
#

href = "https://plus.google.com/share?url=#{url}"
template.$(".googleplus-share").attr "href", href

Expand Down
14 changes: 6 additions & 8 deletions client/views/pinterest/pinterest.coffee
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
Template.shareit_pinterest.rendered = ->
return unless @data

@autorun ->
template = Template.instance()
data = Template.currentData()
data = Template.currentData() || ShareIt.defaultDataContext()

preferred_url = data.url || location.origin + location.pathname
url = encodeURIComponent preferred_url
description = encodeURIComponent data.pinterest?.description || data.description

href = "http://www.pinterest.com/pin/create/button/?url=#{url}&media=#{data.media}&description=#{description}"

template.$('.pinterest-share').attr 'href', href

Template.shareit_pinterest.events
'click a': (event, template) ->
event.preventDefault()
window.open $(template.find('.pinterest-share')).attr('href'), 'pinterest_window', 'width=750, height=650'

Template.shareit_pinterest.helpers(ShareIt.helpers)
Template.shareit_pinterest.helpers(ShareIt.helpers)
24 changes: 11 additions & 13 deletions client/views/twitter/twitter.coffee
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
Template.shareit_twitter.rendered = ->
return unless @data

@autorun ->
template = Template.instance()
data = Template.currentData()
data = Template.currentData() || ShareIt.defaultDataContext()
$('meta[property^="twitter:"]').remove()

if data.thumbnail
if typeof data.thumbnail == "function"
img = data.thumbnail()
Expand All @@ -14,38 +12,38 @@ Template.shareit_twitter.rendered = ->
if img
if not /^http(s?):\/\/+/.test(img)
img = location.origin + img

#
# Twitter cards
#

$('<meta>', { property: 'twitter:card', content: 'summary' }).appendTo 'head'
# What should go here?
#$('<meta>', { property: 'twitter:site', content: '' }).appendTo 'head'

if data.author
$('<meta>', { property: 'twitter:creator', content: data.author }).appendTo 'head'

description = data.twitter?.description || data.excerpt || data.description || data.summary
$('<meta>', { property: 'twitter:url', content: location.origin + location.pathname }).appendTo 'head'
$('<meta>', { property: 'twitter:title', content: "#{data.title}" }).appendTo 'head'
$('<meta>', { property: 'twitter:description', content: description }).appendTo 'head'
$('<meta>', { property: 'twitter:image', content: img }).appendTo 'head'

#
# Twitter share button
#

preferred_url = data.url || location.origin + location.pathname
url = encodeURIComponent preferred_url

base = "https://twitter.com/intent/tweet"
text = encodeURIComponent data.twitter?.title || data.title
href = base + "?url=" + url + "&text=" + text

if data.author
href += "&via=" + data.author

template.$(".tw-share").attr "href", href


Expand Down
15 changes: 10 additions & 5 deletions shareit.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ShareIt = {
settings:
autoInit: true
buttons: 'responsive'
sites:
sites:
'facebook':
'appId': null
'version': 'v2.1'
Expand All @@ -24,7 +24,13 @@ ShareIt = {

configure: (hash) ->
@settings = $.extend(true, @settings, hash)


defaultDataContext: () ->
{
url: location.origin + location.pathname,
title: document.title
}

helpers: {
classes: () ->
ShareIt.settings.classes
Expand All @@ -46,7 +52,7 @@ ShareIt = {

ShareIt.init = (hash) ->
@settings = $.extend(true, @settings, hash)

# Twitter
window.twttr = do (d = document, s = 'script', id = 'twitter-wjs') ->
t = undefined
Expand All @@ -69,7 +75,7 @@ ShareIt.init = (hash) ->
if ShareIt.settings.autoInit
window.fbAsyncInit = ->
FB.init(ShareIt.settings.sites.facebook)

((d, s, id) ->
js = undefined
fjs = d.getElementsByTagName(s)[0]
Expand All @@ -81,4 +87,3 @@ ShareIt.init = (hash) ->
fjs.parentNode.insertBefore js, fjs
return
) document, 'script', 'facebook-jssdk'