Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet cleanup #8

Closed
wants to merge 1 commit into from
Closed

Stylesheet cleanup #8

wants to merge 1 commit into from

Conversation

andrewjrhill
Copy link

@andrewjrhill andrewjrhill commented Oct 11, 2016

Scope

I took the opportunity to cleanup some of the crater package stylesheets after working on Pull Request #5 (see bengott#1).

Feel free to discard if I have overstepped at all here or hit me up on the Crater.io slack (same username).

Work Done

  • Standardised :, {, ,, EOF and newline spacing throughout packages/crater/lib/stylesheets.
  • Updated #fff to $white in ../_global.scss.
  • Removed a rogue ampersand (&) and an empty selector from ../_posts.scss.
  • Removed commented out code from ../_global.scss, ../_posts.scss and ../_variables.scss (version control can be used if this code is needed in the future).

@bengott
Copy link
Contributor

bengott commented Oct 25, 2016

Forgot to say this earlier, but you might also want to check if these problems exist in the base Telescope stylesheets. And if so, submit a PR there too. :)

https://github.com/TelescopeJS/Telescope/tree/master/packages/nova-base-styles/lib/stylesheets

@andrewjrhill andrewjrhill deleted the cleanup/styles branch July 11, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants