Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

topology: add dmic to sof-apl-pcm512x #44

Closed
wants to merge 1 commit into from

Conversation

xiulipan
Copy link
Contributor

@xiulipan xiulipan commented Jul 26, 2018

Add dmic to topology for bxt_pcm512x machine dirver.

work with thesofproject/linux#59

Add dmic to topology for bxt_pcm512x machine dirver.

Signed-off-by: Pan Xiuli <[email protected]>
@xiulipan
Copy link
Contributor Author

Only add STEREO_PDM0.
Test with FOUR_CH_PDM0_PDM1 there will error:

rmbox full of:

0x1ee0 [44.912428] delta [0.000005] dmic eor
0x1ef0 [44.912433] delta [0.000005] dmic eor
0x1f00 [44.912438] delta [0.000005] dmic eor
0x1f10 [44.912443] delta [0.000005] dmic eor
0x1f20 [44.912448] delta [0.000005] dmic eor
0x1f30 [44.912453] delta [0.000005] dmic eor
0x1f40 [44.912458] delta [0.000005] dmic eor
0x1f50 [44.912462] delta [0.000005] dmic eor
0x1f60 [44.912467] delta [0.000005] dmic eor
0x1f70 [44.912472] delta [0.000005] dmic eor
0x1f80 [44.912477] delta [0.000005] dmic eor
0x1f90 [44.912482] delta [0.000005] dmic eor
0x1fa0 [44.912487] delta [0.000005] dmic eor
0x1fb0 [44.912492] delta [0.000005] dmic eor
0x1fc0 [44.912497] delta [0.000005] dmic eor
0x1fd0 [44.912502] delta [0.000005] dmic eor
0x1fe0 [44.912507] delta [0.000005] dmic eor

Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get why you want to do this. I don't have this on my Up2+Hifiberry DAC+. If you want to test you can use the nocodec mode and the DMIC should work. Why is this patch necessary?

@xiulipan
Copy link
Contributor Author

@plbossart
Seems to be the same work like sof-apl-da7219. To make some platform with both capture and playback that can easily test with.

@plbossart
Copy link
Member

@xiulipan the Reef platform handled by sof-apl-da7219 does have dmics. the default platform with Up2+PCM512x doesn't - there are only two platforms in the universe with this config -, and if you want to test you can use the nocodec topology. The only reason why this might be needed is to fix the issue with suspend/resume, where the behavior seems to be different between codec and nocodec mode, but to me this is a development issue and not a reason to keep DMIC forever in this configuration.

@xiulipan
Copy link
Contributor Author

@plbossart
OK. let me close this PR.

@xiulipan xiulipan closed this Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants