[cavs2.5-001-drop-stable] CI backports #8253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a release branch, we shouldn't be using any "latest" docker image. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 94efb26)
Dropping *.yml change from the original commit cause there is no west.yml in this branch. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 3d69a7f) (cherry picked from commit 78302db)
This will make sure platforms without an open-source toolchain available are added to SUPPORTED_PLATFORMS and do not break the -a option Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 8a7a1ad)
This should get rid of most warnings in daily tests ``` Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/ 2022-09-22-github-actions-all-actions-will-begin-running-on-node16... Please update the following actions to use Node.js 16: actions/checkout@v2 ``` Example at https://github.com/thesofproject/sof/actions/runs/3597808171 v3 seems backward compatible. Upgrade only the most used instances for now (most used because of the `matrix` of platforms), upgrade everything in a few days if no issue is spotted. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit f71eb15)
This upgrade was already performed for other jobs in commit f71eb15 (".github/workflows: upgrade actions/checkout@v2 -> v3") and everything went fine. Finish the job and get rid of the last warnings in the daily tests (example: https://github.com/thesofproject/sof/actions/runs/3709176785) stable-v2.2: dropped sof-docs action which does not exist in this branch. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 2ea4bc0) (cherry picked from commit c22378c)
Search and replace checkout@v2 with checkout@v3. This finally gets rid of all warnings "Node.js 12 actions are deprecated". We've been using v3 in a few other places and never met any backwards compatibility issue. Fixed testbench.yml conflict, still embedded in pull-request.yml Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 65a68b7) (cherry picked from commit 7fd3788)
Fixes commit d09844a ("zephyr/docker-build.sh: match UID with 'adduser' instead of 'chgrp -R'") Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit dfc6b46)
sudo-cwd.sh was developed on the main branch for zephyr but now we want to re-use it for building topologies. Cherry-pick only that script, not the zephyr parts. Original commit message: Besides making things more obvious, the important functional change is that the user switch is now performed for _every_ invoked, command, not just for the build command. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 027be98) (cherry picked from commit df10f9f)
This script is now generic. This was not done earlier to be gentle on git blame. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 0a4b1d6)
Fixes commit d09844a ("zephyr/docker-build.sh: match UID with 'adduser' instead of 'chgrp -R'") Also clarify comment and add reference to new sudo-cwd.sh script. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit c28400b)
Support downloads from within the container. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 424da2c) (cherry picked from commit dbcf7e1)
Copying a file that does not exist obviously fails. This bug was found when trying to switch from the current "Developer Image" to the smaller "CI Image": https://github.com/zephyrproject-rtos/docker-image/pkgs/container/zephyr-build Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 75fa04d)
There is a UID mistmatch and file permission problem. sudo-cwd.sh will switch id every docker run command. 80e9c34 was reverted due to missing a toolchain. Signed-off-by: Fred Oh <[email protected]> (cherry picked from commit 745d4cc)
This is a partial fix for thesofproject#7709; doc updates still to be done. Quoting @cujomalainey in - thesofproject#7699 > I still don't see the benefit here. This branch and IPC3 are mostly > stable/archived. Hence anything we fuzz on main we should be able to > cherry-pick down. Nothing new should be landing on this branch so I > don't see the benefit of continued fuzzing past support on main. Quoting @andyross in - thesofproject#7675 > I guess my gut says that fuzzing is a technique for validation of > new code. It has minimal (but sure, not zero) value on maintenance > branches that are expected to be protocol-compatible in perpetuity. Signed-off-by: Marc Herbert <[email protected]> (cherry picked from commit 3ddd15c)
|
Compared to CI checks in for instance recent #8230, this removes the https://sof-ci.01.org/sofpr/PR8253/build13407/devicetest/index.html?model=APL_UP2_NOCODEC&testcase=verify-tplg-binary is also fixed by this PR Testbench failure https://github.com/thesofproject/sof/actions/runs/6277952750/job/17050714146?pr=8253 is caused by unrelated #8241 Quickbuild is still not compatible with release branches (PTS-45980) |
When we added the flags to disable SSP0 and SSP1 on the UP2, we took the shortcut of just removing the PCMs in topology but left the pipelines and widgets in the topology in. While this works in practice to prevent us from testing those SSPs, the right way is to also remove those pipelines also when the SSPs are disabled. This stops tplgtool2.py from complaining constantly about this inconsistency since thesofproject/sof-test#1079 which made the sof-test verify-tplg-binary.sh fail every time: ``` tplgtool2.py sof-glk-nocodec.tplg ERROR: No pcm id=0 for widget=PCM0C ERROR: No pcm id=1 for widget=PCM1C ERROR: No pcm id=0 for widget=PCM0P ERROR: No pcm id=1 for widget=PCM1P ERROR: tplgtool2.py returned 4 ``` This change affects only sof-apl-nocodec and sof-glk-nocodec. Signed-off-by: Marc Herbert <[email protected]> Signed-off-by: Ranjani Sridharan <[email protected]> (cherry picked from commit 9ccfbc4)
marc-hb
requested review from
dbaluta,
cujomalainey,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
marc-hb
requested review from
andyross,
ranj063,
johnylin76,
kv2019i and
Vamshigopal
marc-hb
requested review from
sathyap-chrome,
sathya-nujella,
mwasko and
softwarecki
lgirdwood
approved these changes
Sep 26, 2023
|
@mwasko non runtime CI updates only. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Backports from the stable-v2.2 branch. No conflict.