topology1: sof-hda-generic: remove digital paths #5691
Conversation
These paths are not well supported on all devices and lead to errors such as 17:06:06 kernel: HDA Digital: ASoC: dpcm_be_dai_startup() failed at Digital Playback and Capture (-22) 17:06:06 kernel: Digital Playback and Capture: __soc_pcm_open() failed (-22) 17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: ASoC: error at snd_soc_dai_startup on Digital Codec DAI: -22 17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: ASoC: error at snd_soc_dai_startup on Digital Codec DAI: -22 17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: didn't find PCM for DAI Digital Codec DAI We've already removed this digital path for IPC4/topology2, let's also remove this for topology1. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
requested review from
lgirdwood,
mmaka1,
lbetlej and
dbaluta
as code owners
There was a problem hiding this comment.
UCM wise we seem safe. I didn't find any references to this PCM.
I still wonder whether we should remove this altogether. Removing a capability we used to have can really annoy/surpise end-users. I could imagine we could also add some code to hdac_hda.c to connect the digital PCM to a dummy codec if no pin for digital output is found (like we do with HDMI), to avoid the warnings you mention in bug report. This would still allow to use the digital path if it is available.
It is true the digital path is not well tested at all and maybe shouldn't have been there in the tplg to begin with (although the code has been in hdac_hda.c predating SOF).
|
@kv2019i we don't have any cycles to spend on improvements for this digital device, and we don't even have a 'golden' platform where this is known to work or accessible through e.g. SPDIF I think removal is the only pragmatic thing to do. |
|
SOFCI TEST |
These paths are not well supported on all devices and lead to errors such as
17:06:06 kernel: HDA Digital: ASoC: dpcm_be_dai_startup() failed at Digital Playback and Capture (-22)
17:06:06 kernel: Digital Playback and Capture: __soc_pcm_open() failed (-22)
17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: ASoC: error at snd_soc_dai_startup on Digital Codec DAI: -22
17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: ASoC: error at snd_soc_dai_startup on Digital Codec DAI: -22
17:06:06 kernel: snd_hda_codec_conexant ehdaudio0D0: didn't find PCM for DAI Digital Codec DAI
We've already removed this digital path for IPC4/topology2, let's also remove this for topology1.
Signed-off-by: Pierre-Louis Bossart [email protected]