-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧵 Enhancement/serialization #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @hutchgrant , looks like there is some CSS is missing possibly and also there is body[unresolved]
?
<!DOCTYPE html><html lang="en" prefix="og:http://ogp.me/ns#"><head><!-- Shady DOM styles for app-header --><!-- Shady DOM styles for app-footer --><!-- Shady DOM styles for my-counter --><style>body {transition: opacity ease-in 0.2s; }
body[unresolved] {opacity: 0; display: block; overflow: hidden; position: relative; }
</style>
Did a little research and I don't think there are any styles missing per se since we're not using Shadow DOM in anyway like in Greenwood. If I add this to the Counter component though, then I will see serialized CSS static get styles() {
return css`
:host p {
color: #020202
}
`;
} <!DOCTYPE html><html lang="en" prefix="og:http://ogp.me/ns#"><head><!-- Shady DOM styles for app-header --><!-- Shady DOM styles for app-footer --><!-- Shady DOM styles for my-counter --><style scope="my-counter">my-counter p.my-counter {
color: #020202
}</style><style>body {transition: opacity ease-in 0.2s; }
body[unresolved] {opacity: 0; display: block; overflow: hidden; position: relative; }
</style> As far as Some related activities around this I think are worth looking into when trying this out in Greenwood are:
|
Summary
develop
andbuild
Interesting that Lighthouse would suggest getting rid of the counter component's JS, as that is the actual interactive part. Footer and Header for sure. 🤔

No double renders so far though... 🤞
TODO
console.log
s