Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stderr is not piping back out to the parent process on Windows #22

Closed
1 of 5 tasks
thescientist13 opened this issue Jul 21, 2021 · 0 comments · Fixed by #23
Closed
1 of 5 tasks

stderr is not piping back out to the parent process on Windows #22

thescientist13 opened this issue Jul 21, 2021 · 0 comments · Fixed by #23
Assignees
Labels
0.4.1 bug Something isn't working

Comments

@thescientist13
Copy link
Owner

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Documentation
  • Bug
  • Other (please clarify below)

Summary

Looks like as part of the last release to support #19, when testing within the Greenwood project, any Promise rejections are not "bubbling" their way back the parent process for the command to catch and causing tests to timeout, Windows platform.

 1) Build Greenwood With: 
       Custom Configuration with a bad value for devServer.extensions
         should throw an error that provided extensions is not valid:
     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (D:\a\greenwood\greenwood\packages\cli\test\cases\build.config.error-dev-server-extensions\build.config.error-dev-server-extensions.spec.js)
      at listOnTimeout (internal/timers.js:557:17)
      at processTimers (internal/timers.js:500:7)

Details

Looks like code was commented out in the last release ( 🤦 ) which held this logic, but is good to raise guess as it just needs to be better handled across platforms at minimum, since the equivalent Linux / macOS tests are passing fine.

Should definitely make a test case to reproduce this and make sure it is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4.1 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant