enable the ability to manage processes that do not close

[thescientist13]

Type of Change

• New Feature Request
• Improvement / Suggestion
• Documentation
• Bug
• Other (please clarify below)

Summary

As part of working on trying to test command line applications that spin up servers (like say a livereload server), there is a particular line of code in runner.js that will never resolve() in this case (since a live reload server will never close), thus causing a test runner to hang.

before(async function() {
  await runner.setup(outputPath);
  await runner.runCommand(cliPath, 'develop');
  console.debug('gets here?'); // never gets here and test runner never advances
});

Details

Specifically, this block isn't getting called, thus never fulfilling the Promise

npm.on('close', code => {
  if (code !== 0) {
    reject(err);
    return;
  }
  resolve();
});

So a couple options are:

1. find another event to call resolve() in
2. add a new method to explicitly be able to kill the child process, e.g.

   close() {
     console.debug('manually force close!');
     this.npm.kill();
   }

Leaning towards option 2, which would still require a little boilerplate from the user I believe

before(async function() {
  await runner.setup(outputPath);
      
  return new Promise(async (resolve) => {
    // notice we call it _without_ using await
    runner.runCommand(cliPath, 'develop');
        
     setTimeout(() => {
       resolve();
     }, 3000);
  });
});

...

after(function() {
  runner.close();
});