-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support noPropertyAccessFromIndexSignature tsconfig option #160
Support noPropertyAccessFromIndexSignature tsconfig option #160
Conversation
Removed RecursivePartial<T>, instead introduced AsObjectPartial, which is used as fromObject method argument. Make getters, setters and AsObject typed according to canHaveNullValue predicate. Brought AsObjectPartial into line with constructor's declaration.
Change method access in RPC from property access to element access.
Hey, I have reproduced the error with windows-latest 14.x, but it affects not only this PR. This error also appears when running tests on thesayyn:main branch. I am not sure what exactly caused this PR to fail, but i believe the problem is somewhere here: https://github.com/bazelbuild/rules_nodejs/blob/aa09b5796faaf2470b84246a8f00e6e27181c63b/internal/common/windows_utils.bzl#L108 The file generated by the rule above is located at
And quotation marks cause the bat script to fail. I think it is because |
That's weird. i think we can fix it by using the util from https://github.com/aspect-build/bazel-lib/blob/main/lib/windows_utils.bzl. I'll have a look at this. Let's not worry about windows tests failing. Would it be possible to not base this PR on others? I'd love to land small changes at a time. |
Closing as there's been no activity on this. |
Reated to #154
Tsconfig options
noFallthroughCasesInSwitch
,noImplicitReturns
andnoPropertyAccessFromIndexSignature
are enabled in all tests.Options
noFallthroughCasesInSwitch
andnoImplicitReturns
required no changes.Option
noPropertyAccessFromIndexSignature
required to change method access in RPC from property access to element access.