Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support noPropertyAccessFromIndexSignature tsconfig option #160

Conversation

Santalov
Copy link

@Santalov Santalov commented Jul 29, 2022

Reated to #154
Tsconfig options noFallthroughCasesInSwitch, noImplicitReturns and noPropertyAccessFromIndexSignature are enabled in all tests.

Options noFallthroughCasesInSwitch and noImplicitReturns required no changes.

Option noPropertyAccessFromIndexSignature required to change method access in RPC from property access to element access.

@Santalov Santalov changed the title Support no property access from index signature Support noPropertyAccessFromIndexSignature tsconfig option Jul 29, 2022
@Santalov
Copy link
Author

Hey, I have reproduced the error with windows-latest 14.x, but it affects not only this PR. This error also appears when running tests on thesayyn:main branch. I am not sure what exactly caused this PR to fail, but i believe the problem is somewhere here: https://github.com/bazelbuild/rules_nodejs/blob/aa09b5796faaf2470b84246a8f00e6e27181c63b/internal/common/windows_utils.bzl#L108

The file generated by the rule above is located at protoc-gen-ts\bazel-out\host\bin\external\npm\typescript\bin\tsc.bat and has a line that looks like this:

"" -c "!run_script! !args!"

And quotation marks cause the bat script to fail. I think it is because ctx.toolchains["@bazel_tools//tools/sh:toolchain_type"].path (check the link above) is empty, but i don't know why and how to solve it.
I need help. I have tried to update @bazel/typescript, build_bazel_rules_nodejs and @bazel/jasmine up to v 5.5.3, set tsc param of the ts_project function to "@npm//typescript/bin:tsc", but achieved nothing.

@thesayyn
Copy link
Owner

That's weird. i think we can fix it by using the util from https://github.com/aspect-build/bazel-lib/blob/main/lib/windows_utils.bzl. I'll have a look at this. Let's not worry about windows tests failing.

Would it be possible to not base this PR on others? I'd love to land small changes at a time.

@thesayyn
Copy link
Owner

thesayyn commented Sep 1, 2023

Closing as there's been no activity on this.

@thesayyn thesayyn closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants