-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Basic] Task 6 Passing Parameters to Class Constructors #21
Conversation
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 5 6 +1
Lines 8 11 +3
=======================================
+ Hits 8 11 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start 🙌 Let's clean up the presentation a bit by adding a proper title and description.
We also need to add the Basic06
and Basic06Test
as well.
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slowly getting there. Let's add a proper title, something like:
[Basic] Task 6 Passing Parameters to Class Constructors
Then let's add a proper description, something like:
This adds a basic task to illustrate how to pass parameters to a class via the class constructor.
We still need a Basic06Test
, this should be as easy as copy and pasting the Basic06SolutionTest
content to the newly defined test class.
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to add Basics06Test
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
solutions/src/main/kotlin/de/thermondo/solutions/basics/Basics06Solution.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing to fix before merging.
Description
This adds a basic task to illustrate how to pass parameters to a class via the class constructor.
Review checklist