Bundle of fixes/updates for WorldPay JSON Gateway #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leith - looks good. |
* Fix incorrect response class being generated (causes card declines to be accepted) * Fix purchase response message to actually have failure reason if available (instead of an error from no 'message') * Add more docblocks * Add proper abstract function definition for getEndpoint * Abstract JsonAuthorizeResponse to reduce duplication * Update unit test coverage, including distinction between failure, error and malformed cases * Add JSON gateway to README
|
@delatbabel Any news on this one? I'm looking at integrating WorldPay but the issue @leith uncovered is alarming. |
|
@delatbabel maybe this can be merged? |
|
@delatbabel @lukeholder If it's any help, I've confirmed the problem @leith describes exists against a WorldPay account and that this PR fixes the problem. Would be great to get this merged. |
|
Merged and tagged v2.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from writing an integration after @lukeholder's #22 was merged. I'm not entirely sure how @ugin is able to use this commercially because at the moment, the library will treat declined cards as successful payments.
This is what I've done:
It's also worth noting that the
JsonCaptureRequestclass still has no unit tests - I'm not using it in my current integration yet, so I'm unlikely to add more coverage for this any time soon. Hopefully someone using it will be able to look into that in more detail.