Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not treat an empty card as a provided card #158

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Wiping out the whole array is pretty extreme. Only do it if the card array actually has
meaningful values. The code that calls this might be trying to support multiple
processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay

#157 (comment)

@eileenmcnaughton
Copy link
Contributor Author

travis issue seems larger than this PR

eileenmcnaughton added a commit to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor that referenced this pull request Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158
will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card
@eileenmcnaughton
Copy link
Contributor Author

Note that by contrast Paypal Rest create card request actually requires an object - even when empty - https://github.com/thephpleague/omnipay-paypal/blob/master/src/Message/RestCreateCardRequest.php so it's hard to support both without this

eileenmcnaughton added a commit to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor that referenced this pull request Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158
will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card

Also declare support sagepay alternate function choices per
thephpleague/omnipay-sagepay#157
eileenmcnaughton added a commit to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor that referenced this pull request Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158
will be merged but for now SagePay assumes that an empty card should be filtered out
eileenmcnaughton added a commit to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor that referenced this pull request Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158
will be merged but for now SagePay assumes that an empty card should be filtered out
eileenmcnaughton added a commit to eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor that referenced this pull request Jan 10, 2021
Hopefully thephpleague/omnipay-sagepay#158
will be merged but for now SagePay assumes that an empty card should be filtered out
@judgej
Copy link
Member

judgej commented Jan 10, 2021

If you want to merge from master into this branch, the tests should now pass.

Wiping out the whole array is pretty extreme. Only do it if the card array actually has
meaningful values. The code that calls this might be trying to support multiple
processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay

thephpleague#157 (comment)
@eileenmcnaughton
Copy link
Contributor Author

done & travis is trying again!

@eileenmcnaughton
Copy link
Contributor Author

And it's green!

@judgej judgej merged commit 84f1a22 into thephpleague:master Jun 21, 2021
@eileenmcnaughton eileenmcnaughton deleted the card branch June 22, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants