-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not treat an empty card as a provided card #158
Conversation
travis issue seems larger than this PR |
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card
Note that by contrast Paypal Rest create card request actually requires an object - even when empty - https://github.com/thephpleague/omnipay-paypal/blob/master/src/Message/RestCreateCardRequest.php so it's hard to support both without this |
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card is an ignore-everything-else-card Also declare support sagepay alternate function choices per thephpleague/omnipay-sagepay#157
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
Hopefully thephpleague/omnipay-sagepay#158 will be merged but for now SagePay assumes that an empty card should be filtered out
If you want to merge from master into this branch, the tests should now pass. |
Wiping out the whole array is pretty extreme. Only do it if the card array actually has meaningful values. The code that calls this might be trying to support multiple processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay thephpleague#157 (comment)
d92bfdc
to
5dc3792
Compare
done & travis is trying again! |
And it's green! |
Wiping out the whole array is pretty extreme. Only do it if the card array actually has
meaningful values. The code that calls this might be trying to support multiple
processors so don't assume it 'knows' not to pass an empty card if the processor is sagepay
#157 (comment)